Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp221176pxb; Wed, 3 Feb 2021 04:02:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJygt/yRHkmp3HqIJ0zFCcCxd0FAJJfGGlJ/qWhNGxWJ0SfOlfD0G/SYg1u0ByQ+faioYn3g X-Received: by 2002:a05:6402:34d2:: with SMTP id w18mr2664665edc.102.1612353743840; Wed, 03 Feb 2021 04:02:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612353743; cv=none; d=google.com; s=arc-20160816; b=oE00FzNke2h3XeHRkFSdEx685sr91PbapCqCHWaTCKvgiLHT3XG1tN41ujQhuiwxkt lpdhSiHD2Z4tjC023MPI32s78xcTREIr3n39H2J6S84JiWAkMZ4afcrEauIOKjw5tZGl mCVSqQZI9lDJAG4rhodLgEBPEEbvWGLVzmzvO042YLd2EebIg31JYamVkgNHAFOE7rEx yq/AEC4O0R0Ks31dGFM6vD4hoQNQTBiPeFR0em2D6NAaV3vJPOABLluS8P25zfuI8JTU K3QLfo95vYCKQW6kHNWKSN0rsAfrl7Ipb4ziJ9Y0fau6CQ5gF6T2FxbMywVtVnvS4cab c19A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=G7jTqf1S5uwG7RY/vl9pnFb5uLY8FUuyRxKDwAXEe7s=; b=eH10bhxAyh0uPJtM4hzlD8ZX0VMd6r3z13t0tY8xGt/gXCY2s4QTN61B4p5t670+EC ZR5py6vTIsu4wkMoc3Pf+lJ4XMgMb+/Kcgx3slAcw15HcQQYcyFH72svh3pfoUrlM2G4 44KANoGBX+0MENOKon77DuqdQL4siL9t82Qb6bdPgZ8ONg1F3APW5JDfxxj8wG0codH+ 1hG49XDESH3uqUmsQSvM7k8VEOxeOtLV9npjndGwAIshfWjsWv3KiWH4Orw7LFvYVY+G F8Ot8yWe2KKrmM35I9BTHAgv2q1wZTqBVZsvzopZEitXRB3Zlg191peKJ9TpqwcZorhV 6jSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f11si1242624ejw.77.2021.02.03.04.01.59; Wed, 03 Feb 2021 04:02:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234310AbhBCL6g (ORCPT + 99 others); Wed, 3 Feb 2021 06:58:36 -0500 Received: from mx2.cyber.ee ([193.40.6.72]:35513 "EHLO mx2.cyber.ee" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233972AbhBCL6f (ORCPT ); Wed, 3 Feb 2021 06:58:35 -0500 Subject: Re: [PATCH v2] sched/topology: fix the issue groups don't span domain->span for NUMA diameter > 2 To: Barry Song , valentin.schneider@arm.com, vincent.guittot@linaro.org, mgorman@suse.de, mingo@kernel.org, peterz@infradead.org, dietmar.eggemann@arm.com, morten.rasmussen@arm.com, linux-kernel@vger.kernel.org Cc: linuxarm@openeuler.org, xuwei5@huawei.com, liguozhu@hisilicon.com, tiantao6@hisilicon.com, wanghuiqiang@huawei.com, prime.zeng@hisilicon.com, jonathan.cameron@huawei.com, guodong.xu@linaro.org References: <20210203111201.20720-1-song.bao.hua@hisilicon.com> From: Meelis Roos Message-ID: Date: Wed, 3 Feb 2021 13:57:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210203111201.20720-1-song.bao.hua@hisilicon.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 03.02.21 13:12 Barry Song wrote: > kernel/sched/topology.c | 85 +++++++++++++++++++++++++---------------- > 1 file changed, 53 insertions(+), 32 deletions(-) > > diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c > index 5d3675c7a76b..964ed89001fe 100644 > --- a/kernel/sched/topology.c > +++ b/kernel/sched/topology.c This one still works on the Sun X4600-M2, on top of v5.11-rc6-55-g3aaf0a27ffc2. Performance-wise - is the some simple benhmark to run to meaure the impact? Compared to what - 5.10.0 or the kernel with the warning? drop caches and time the build time of linux kernel with make -j64? -- Meelis Roos