Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp246926pxb; Wed, 3 Feb 2021 04:43:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJyDZk1GV6ySJMBROY+bchpoNfWm201UCUIFwRsPU+VjW9Uorz5TLY06qzjfIFKPuvxyJ3T9 X-Received: by 2002:a05:6402:34d2:: with SMTP id w18mr2844730edc.102.1612356216148; Wed, 03 Feb 2021 04:43:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612356216; cv=none; d=google.com; s=arc-20160816; b=kqxRRnwLASfF5Wa+g8McwuayUi3Ytut31vgvdDT8cJurl5dnGfNodE2rCLd1apu/wm dMX2rzz0RNwUFPF5jkhMbXE5f+JV6T2G78LY/86GP3x4AQR/fWUs0mkgnEGKt7PAkzdC jUfniDkfZxWMx4+RwnCKjtygCRAsDbDsoZCzdj8HfI/nzaUdLOFU5FvH+lqht1NzoUdk byuKRvQe3dWBC5cy8LlFsYVeXyjo6JnoRk3ZRb/dnps+Z6yEv4l0XPRdKyevdEWhf7gT Ak2ikWwmY+pe9W1aBxn9Mxxwxdlm9fLkUPD16VgZtgM0ZlthyROJEoSg+8XgEoII2eun zn2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:dkim-signature; bh=/ULVtfk6VXfej33sFyXrP77hyiB+SZsc1iDOxjrIH7Y=; b=B6PyL/tfZGaB+e+U4OgYY+Sx5p0erSt2DCokKSANcGY1Nvz3QrES5bs+AqjeOGi6Ds Mc8ErjvGZTEMrC5PoyIPbhYEPD04e6A1Boz8BBPhKxLyA6288fbupei87C99H4HwGlxe FSLiMj2uZBuBIy0+CerUW4saekjvr4jOho+eCGE9IlG2IzMuG0k741ofubC/OiXDRuWe g9VzVFZV458lKKqM+PnD6JIp+bU3/133SEKYXSQmFrO91kdq271BGzaX6KCc+GaRcMWg wOagMAlpNABpN5CFH0dxxgs+snLnPaFA+9CQczZBDyIIG7Tg/F6K4fpX0EkNwRTiHsKL j6YQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=QAACZ9Su; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i24si1131977edg.295.2021.02.03.04.43.11; Wed, 03 Feb 2021 04:43:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=QAACZ9Su; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231135AbhBCMkU (ORCPT + 99 others); Wed, 3 Feb 2021 07:40:20 -0500 Received: from esa.microchip.iphmx.com ([68.232.154.123]:55739 "EHLO esa.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231159AbhBCMjt (ORCPT ); Wed, 3 Feb 2021 07:39:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1612355988; x=1643891988; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=AdTHEClqq4Qqa1lO3aXnEWNDtT86vAA8Mw0krUz2ZYc=; b=QAACZ9Su+mOzwGHzJXtfsiBSJkdqj8QTbWQlUArA+Uti/IubC8TkTe+3 S3QPZWQ0zUK0hCAbYmKgSdlOmSxLBZjAysxF7G6VtEeFaOzrmaNpcyawD a+FMMtUgKL0NFFg1dv2PCB5E6LEVpFZkRC4k0PisfjpEQpWpVGAmgHK4i xgKhiCBgpVTsPwO9NTtJenBijTDtV8UDtUwkHmU+fbL/0mBAT6pgW+o2i 8/GJ8e0cLirBciVxJBOgKW/rgqZjQSKOU+/3gAwLU0jhFby+XfHA19Uk2 S0ZV5wBES15bNJIcgiJ9XGlbBQVQ0GFe2N8Mi/ljWyxjYEBVfk81gJ+At g==; IronPort-SDR: Tts59nglJzw2kUzKY/ZWi0grf4sq4u7+ryxOl8/LFzAsXTZKITbjASo91bPDxgt0FLBRgx2N7L h6R14gPCfUpo3H0NyQXVALEUtxUvW+6yZq9aA7fHoR/hpe2zD470mEu81LEofOJvk+ivsbnR26 hqIt0sURKAXNtGFgRQuaR98cb6JnbS5GPvC7TgMTOdCGWrC614o2Z4MvgGZcFyn/mcmBKLPPkm edJ3xg2rwtkst9teD84cajjgBou1+9fViRd9Cm7qEeotem+d2RRk7b37qCVCGtDZ5sGgMgIZBB C5o= X-IronPort-AV: E=Sophos;i="5.79,398,1602572400"; d="scan'208";a="42754787" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 Feb 2021 05:38:30 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 3 Feb 2021 05:38:30 -0700 Received: from soft-dev10.microsemi.net (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Wed, 3 Feb 2021 05:38:28 -0700 From: Lars Povlsen To: Linus Walleij CC: Lars Povlsen , Microchip Linux Driver Support , , , , , "Gustavo A . R . Silva" Subject: [PATCH 1/1] pinctrl: pinctrl-microchip-sgpio: Fix wrong register offset for IRQ trigger Date: Wed, 3 Feb 2021 13:38:25 +0100 Message-ID: <20210203123825.611576-1-lars.povlsen@microchip.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch fixes using a wrong register offset when configuring an IRQ trigger type. Fixes: be2dc859abd4 ("pinctrl: pinctrl-microchip-sgpio: Add irq support (for sparx5)") Reported-by: Gustavo A. R. Silva Signed-off-by: Lars Povlsen --- drivers/pinctrl/pinctrl-microchip-sgpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c index 6a43edefa490..61ba245bd0f8 100644 --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c @@ -574,7 +574,7 @@ static void microchip_sgpio_irq_settype(struct irq_data *data, /* Type value spread over 2 registers sets: low, high bit */ sgpio_clrsetbits(bank->priv, REG_INT_TRIGGER, addr.bit, BIT(addr.port), (!!(type & 0x1)) << addr.port); - sgpio_clrsetbits(bank->priv, REG_INT_TRIGGER + SGPIO_MAX_BITS, addr.bit, + sgpio_clrsetbits(bank->priv, REG_INT_TRIGGER, SGPIO_MAX_BITS + addr.bit, BIT(addr.port), (!!(type & 0x2)) << addr.port); if (type == SGPIO_INT_TRG_LEVEL) -- 2.25.1