Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] leds: lp50xx: remove unused regulator
To:     Pavel Machek <pavel@ucw.cz>,
        Sven Schuchmann <schuchmann@schleissheimer.de>
CC:     Rob Herring <robh+dt@kernel.org>, <linux-leds@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20210203083408.2534-1-schuchmann@schleissheimer.de>
 <20210203090249.GA14154@amd>
From:   Dan Murphy <dmurphy@ti.com>
Message-ID: <2e9dff78-7fde-404d-6fad-6aeedf1145d1@ti.com>
Date:   Wed, 3 Feb 2021 07:49:35 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210203090249.GA14154@amd>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

Pavel

On 2/3/21 3:02 AM, Pavel Machek wrote:
> On Wed 2021-02-03 08:34:08, Sven Schuchmann wrote:
>> The regulator for vled-supply is unused in the driver.
>> It is just assigned from DT and disabled in lp50xx_remove.
>> So the code can be removed from the driver.
> Dan, what is going on here? Do we need to also enable the regulator,
> or is the removal correct thing to do?
>
I think it would be better to do an enable as opposed to removing the code.

This would be needed especially in applications that have to meet strict 
power management requirements.

Users may want to disable or enable the regulator during suspend/resume. 
Otherwise it would be considered always-on and the regulator does not 
need to be populated.

Dan