Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <91e3405245c89f134676449cf3822285798d2ed2.1612189652.git.michal.simek@xilinx.com>
 <CAL_JsqJnu1M6ut8g_36ve-OG22jFsySHbmVHOgtDRhc-s37rpQ@mail.gmail.com> <210b0e5a-767b-c285-62e2-23de19bd3cf1@xilinx.com>
In-Reply-To: <210b0e5a-767b-c285-62e2-23de19bd3cf1@xilinx.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Wed, 3 Feb 2021 08:12:08 -0600
Message-ID: <CAL_Jsq+m7F+nD6VKd2L5i44hz32_-6iX3toZ0A0CBT-g7Xqu9g@mail.gmail.com>
Subject: Re: [PATCH] ARM: dts: zynq: Add address-cells property to interrupt controllers
To:     Michal Simek <michal.simek@xilinx.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Michal Simek <monstr@monstr.eu>, git <git@xilinx.com>,
        Andre Przywara <andre.przywara@arm.com>,
        devicetree@vger.kernel.org,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Feb 3, 2021 at 1:01 AM Michal Simek <michal.simek@xilinx.com> wrote:
>
>
>
> On 2/1/21 6:41 PM, Rob Herring wrote:
> > On Mon, Feb 1, 2021 at 8:27 AM Michal Simek <michal.simek@xilinx.com> wrote:
> >>
> >> The commit 3eb619b2f7d8 ("scripts/dtc: Update to upstream version
> >> v1.6.0-11-g9d7888cbf19c") updated dtc version which also contained DTC
> >> commit
> >> "81e0919a3e21 checks: Add interrupt provider test"
> >> where reasons for this checking are mentioned as
> >> "A missing #address-cells property is less critical, but creates
> >> ambiguities when used in interrupt-map properties, so warn about this as
> >> well now."
> >>
> >> Add address-cells property to gic and gpio nodes to get rid of this warning.
> >> The similar change has been done for ZynqMP too.
> >
> > FYI, we're going to make this check dependent on having an
> > interrupt-map property. So adding these isn't necessary.
>
> Good to know. Is there going to be report if interrupt-map doesn't
> exist? Which can end up with reverting these changes?

You mean a warning if '#address-cells' is present and interrupt-map is
not? No, that would cause lots of warnings.

Rob