Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp318865pxb; Wed, 3 Feb 2021 06:26:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJzi8DzUr0t5HdYmkgMCSvsx6XFFWAFv19mejrX6mjXtGcq8HQixrNalKQI4EtwueGwETEIQ X-Received: by 2002:aa7:dc0d:: with SMTP id b13mr3229377edu.170.1612362380712; Wed, 03 Feb 2021 06:26:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612362380; cv=none; d=google.com; s=arc-20160816; b=cqi5HtsLZ/P1blQlcnkL4GFMU+U4T8iom2b0F+eSQCJCReVMNKhdnyUMS/tWnxHVeB 9PhAPS7Y9LpqEvXrr7lcDtyrmKd4+ss3cQOiIJifP2HpwYSuWpGytBU8Jav5ndfvf5B3 o+xdz8z7NOFrvDkF+jl1KulAnObAy7QImgm+s8wYucRA+KRppoSV+Pj2mTBpNsZI+YJN z8WuHa61bvaSj3z/fiXsnHc5NBmS/UpXpex7I3gDAGJdsPN1I4Os9BkUAGzpS2Sh/AOo SsLbXAcJbzceP5qBLjTaFVtWo4F/kdl79RfAsZjirhrC++yYzjvepNiIECDzy1S/0h0e FYTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/IkMIg+/G16dUtGJvy8Lqc+8sFZ9w36477Rgfa2i+ho=; b=rADnOIwrXVjSXKJg8JymhVvznLXCup4WBl5X09lKXHzsMvM6DdxG8mtAlqk35R0QU5 ikRmTWdSAgwdZjzmJvIetw7BwhgRDXmMFq7nLI4J0GVF0pBWPOCavIbnW68mDY1O6d59 Z6+Rbrh+L9VHq84jnLZ3I85SC8QYLR9rTEH+hJ8SRbIoFQvFEg7EJd6lqeMbNaKq68KM jPIBy4naQYbhPO0/JQX48slc6hgW28bu+/Jt+QKd6S1GhZkP1Dvc9tpsqie3RpCMzNoi GpJPnKnczjPdBHwnLPoTQyEmzdMEvWQsq1Bf6taLG84ExXgz20Zzjv/N7H3QM8Qawdop UEsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=e+pB5MUE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jx12si1415875ejb.247.2021.02.03.06.25.55; Wed, 03 Feb 2021 06:26:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=e+pB5MUE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232661AbhBCOWh (ORCPT + 99 others); Wed, 3 Feb 2021 09:22:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232577AbhBCOWb (ORCPT ); Wed, 3 Feb 2021 09:22:31 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 747BDC061573 for ; Wed, 3 Feb 2021 06:21:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/IkMIg+/G16dUtGJvy8Lqc+8sFZ9w36477Rgfa2i+ho=; b=e+pB5MUE2BUYiuA4boO/c/oelt VvF3P82IKu86r7sO3wB6cTWdc9Ne6+aWacTGr50N4vQO2IAnf3pTi1qNPUG2uVbM00SHF5u5+VmdK GNTOgDzE0fhw77+ihUQC1DWMSoXZMwx3cixP6coisQOEiuXS7ji5l67Zo2H8T3NtJMemcYMDh1oAP SsV7BOMFlwa+8qEpNAcPMF11Lh/z/zwAfgGw2+cuFM8PK2b5Sraphhz8+wGFWND8OdCSiX/hOZXeB A9ylE6ryk3UunxNVm1rcLq3cUOpo2/qVeeu/OlCSAk5yJrTv566E4bg4gDUh9VPaD+uoE3jJ5UXmv dFmgxfvw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1l7J2C-00H112-PX; Wed, 03 Feb 2021 14:21:33 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 20169301179; Wed, 3 Feb 2021 15:21:31 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id DDEF9203D8391; Wed, 3 Feb 2021 15:21:31 +0100 (CET) Date: Wed, 3 Feb 2021 15:21:31 +0100 From: Peter Zijlstra To: "Zhang, Rui" Cc: "mingo@redhat.com" , "acme@kernel.org" , "mark.rutland@arm.com" , "alexander.shishkin@linux.intel.com" , "jolsa@redhat.com" , "namhyung@kernel.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "kan.liang@linux.intel.com" , "ak@linux.intel.com" Subject: Re: [PATCH 2/3] perf/x86/rapl: Fix energy counter detection Message-ID: References: <20210115092208.20866-1-rui.zhang@intel.com> <20210115092208.20866-2-rui.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 17, 2021 at 02:44:04PM +0000, Zhang, Rui wrote: > > But it doesn't fix anything.. there's not anything broken, except on that daft > > SPR thing. > > Well, yes. > Before SPR, this is just a potential issue. But things on SPR suggests > that this potential issue may become a real one. So are you > suggesting me to also include the SPR information as the justification > of this patch? Yes, and fix the subject. It doesn't fix anything, as there isn't anything broken. Just say that upcoming SPR will need this.