Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: xmjehtclWrZdePEoCrgP3L6vpAWXdy8gGAzNUTTMf+iCx1YJotDAD4QLGrScw1QxjUiEu8UCMi
 fftYC/7R0oqw==
IronPort-SDR: U3OqqYgN/+6KwvpAI4cQ7LwNktWJ2QKpO2e4cQlX0+S650abr2HF9vUKLur5WFoTRNDKP1HhIU
 t8CrgqOBb5Wg==
Date:   Wed, 3 Feb 2021 17:01:21 +0200
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Kyle Tso <kyletso@google.com>, gregkh@linuxfoundation.org,
        hdegoede@redhat.com, robh+dt@kernel.org, badhri@google.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/8] usb: typec: Manage SVDM version
Message-ID: <20210203150121.GI1687065@kuha.fi.intel.com>
References: <20210202161733.932215-1-kyletso@google.com>
 <20210202161733.932215-2-kyletso@google.com>
 <20210203124724.GD1687065@kuha.fi.intel.com>
 <20210203145143.GA58095@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210203145143.GA58095@roeck-us.net>
Precedence: bulk

On Wed, Feb 03, 2021 at 06:51:43AM -0800, Guenter Roeck wrote:
> Thinking about it, would it make make sense to define the functions as
> static inline ?

I (and I believe Guenter too) want to keep these structures protected
for now. If the API starts to get too bloated, then I guess I have to
reconsider that. But I don't think we are there yet.

I have been thinking about moving the USB PD negotiation details to a
separate structure that could be more accessible for everybody. That
should allow me continue to protect my precious structures. But I have
not yet put much though into that.


thanks,

-- 
heikki