Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp381143pxb; Wed, 3 Feb 2021 07:42:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJzaM5XV+5z6J3yFB+0vDmoiPQ2mQOoeSsvqSOjNlu0tl1bcd/QXVtZgqlXNY1Ds6KNXpG+9 X-Received: by 2002:a05:6402:702:: with SMTP id w2mr3671134edx.78.1612366920453; Wed, 03 Feb 2021 07:42:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612366920; cv=none; d=google.com; s=arc-20160816; b=zPf38/tuW0RCtddJMURtdbFMATGJiOiWX5SdJ6AGqAAAxjGw3lxj6T0ig74s8lEKLK cw1EHfQXr4D/Ilo+/oRif/hbjD9jayQqNpMkXQrwRnSCo6whv7x58GQNaCKcWnAoWqgC hC+Z67C7ZkNYJeI+GM5uPwrn68VJbvSgTKDUI2JZ5VX9YxBS23V0L/IY6pmceeivFprO cOlEdOk3JqG+p0ELG0i/2KUz9MEnxuNzfN5R8qvJpqxBx3ASzCx6p94eAfiHNyoL/lsk vl52Q4ETQYB3zJ2Xo3oKVBx8iO/TezOJTuEsx5hU0JtqwjefkRYhxL+InisiocNQTCbe cQ8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9UTXzu3/+6k9aa8z16gApXfils5sQmSVrhO9HgfmKEw=; b=lnto4md74SErluhxdCMTHw7inC9DiOPpkZ1HqYE1EKAN5ArJEF8MVDBwuvE+N21flo F5M4qopBKf5+Yud5/SHlikNIIOHGyqUMTPyrohHpEM9LeIZ4D+1u+ZbCtWglCX3JxkqE MX6ZHIGVFiVshN6fkxHSlIg6Vr11McXFjHm81v4MiIizBRaLnAomZh00IBpki8g2Q8CA ZvaMP3XVnHLqcsqIFQOM+jDta770/j6Q6ETI31y7Y6Lp3oghQZyOtrG9HqBaav2m50L7 IniBS2eVpa/z2HhIf98zvn/KHWnpc6ktiplP7Zql9YrshHCIUNlyM8TyA+bA/6ZG7uoe 2hbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MGpCorwV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m13si1720668edi.144.2021.02.03.07.41.34; Wed, 03 Feb 2021 07:42:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MGpCorwV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234500AbhBCPim (ORCPT + 99 others); Wed, 3 Feb 2021 10:38:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:57794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234549AbhBCPhN (ORCPT ); Wed, 3 Feb 2021 10:37:13 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3308464DF6; Wed, 3 Feb 2021 15:36:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612366592; bh=G8HiIlIOtnUi7ov/aeZ2j8ezEwCl5j40erKG29Mr8M4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MGpCorwVuW893pfuqQgRoJSX2xc4a/6vDBOvTGBp4ZC6ZH7paH3CqwEID31oCxG9Q +yfMoylsuWzn/fPo3iwBJABXdIM7oUMszENn92bsIxCH37E449qQfSYb8vYi45dlH+ 4oQ4Jx4Gw340lqkduLigOhzhedXkOR0zvclb9TMK9hFZmUyhakLuzzMLrL1sezaypb pO7CfB1GMVbN47DKD0DCZPPlR3F9PQtLWJ+VamG1QSE/xX9HASfcDAOjpxkwMNDTnh FB5TxldX7ZTs/1B6CQS3OdK9ywLmbm+MfjQ+Rw7Mw0af2NSeOKvkC5CkTffkkmRfRQ CeHE2myCQA7Xw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 1E64E40513; Wed, 3 Feb 2021 12:36:29 -0300 (-03) Date: Wed, 3 Feb 2021 12:36:29 -0300 From: Arnaldo Carvalho de Melo To: "Jin, Yao" Cc: John Garry , jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH] perf metricgroup: Fix segmentation fault for metrics with no pmu event Message-ID: <20210203153629.GD854763@kernel.org> References: <20210202022424.10787-1-yao.jin@linux.intel.com> <77af7dc5-eac4-4591-cba7-8937c94a058f@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Feb 03, 2021 at 08:46:52AM +0800, Jin, Yao escreveu: > On 2/2/2021 4:15 PM, John Garry wrote: > > On 02/02/2021 02:24, Jin Yao wrote: > > > It causes the segmentation fault. Now check the pmu_name before strcmp. > > > Fixes: c2337d67199a("perf metricgroup: Fix metrics using aliases covering multiple PMUs") > > > Signed-off-by: Jin Yao > > This should be fixed in v5.11-rc6 - please check it. > > 9c880c24cb0d perf metricgroup: Fix for metrics containing duration_time > Oh, I see, your patch is in Arnaldo's perf/urgent branch. Sorry about that, > I just tested Arnaldo's perf/core branch. :( As soon as I finish processing patches today and get perf/core thru the usual set of tests, it'll all be in perf/core. - Arnaldo