Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp382904pxb; Wed, 3 Feb 2021 07:44:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJy6xbLG8XfNRTGygtfyYSj9K4lWvee6gNogc/Q+vBDMKGpVaxpyjarkq1LYHuwDcdJcbnzu X-Received: by 2002:a17:906:4c90:: with SMTP id q16mr3880382eju.49.1612367068190; Wed, 03 Feb 2021 07:44:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612367068; cv=none; d=google.com; s=arc-20160816; b=PU5NWiRCsg9L8jphx1RQRF0+vTyKyWu9SAHI+6rFdmw4ST7ztwBownP1z8Tdw88uGL w28wh2Kkx7g9K+Ha7M1EpCYZYA6SOWsgONwnuDX1TXPltQGKGcnazBu7GS0aXY+J19BW 52S2JR9ZVIFH/Yyt/Ylg+vQq9sHnEDlfIOjPL+u4w/wUB8v9FI86G1Sa0LPVtOjTcMTk aOCtwNrkUbsdoFmqSCFYy2XNXzflVDQE/nUBqm5EiM7XWHSm9RulcHzUdRxDIZUQfVrt xtAgIfGSNPZJFw5JdR+BIepK63JcCM0YsnHLUcSrAv7uyaEfDvjJs7BW3PsU/iUeFj3m P3MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=Ag0kcUd7rdUz3BiLNLNnxT/HvWG3hkdmf5uEHTJIQ1Y=; b=uQZptfnvS0xZXVNa78t3Wl1b/KIutUQ2vEaCg4ZZVVRqOJUa0MyfYRh1dY4UZT/dgk WpeVu++b7JVT6zFEfC6m3pcpy0LHVF0DlIdjjaJMKq3Vnv3SDr4qEJE6EZYn2niFbbyJ 4jcob00EcPwmReObWcEevpZaCbtp4G1dGviJ5oXI6J0sU47FgOsWjYYdSZidmVuKTdJQ 4ptXLBOt/2ebww3Pe9DF4l0Tc2ctpZ9DCpAEigKBtQOAfclVTrDAduiBV4exu6QfYe/O ev5j9jLcd3ZItYpr6d81tJKqLBa6eFKoyU3gUEY+lTpf5ZLmdzDXbYTwqBfB1DGsO7ci J8jA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w17si1653947ejy.52.2021.02.03.07.44.03; Wed, 03 Feb 2021 07:44:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234612AbhBCPmp (ORCPT + 99 others); Wed, 3 Feb 2021 10:42:45 -0500 Received: from mga12.intel.com ([192.55.52.136]:64399 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233963AbhBCPku (ORCPT ); Wed, 3 Feb 2021 10:40:50 -0500 IronPort-SDR: DfDsVsfpjLo8Avqbz3XdEHNhJs1zvDqIeEvau4akULVRKaG6iAQ1+RoYF9VQxV8p0XNrZgjva9 9vaYQiKiiKSw== X-IronPort-AV: E=McAfee;i="6000,8403,9884"; a="160225206" X-IronPort-AV: E=Sophos;i="5.79,398,1602572400"; d="scan'208";a="160225206" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2021 07:40:09 -0800 IronPort-SDR: oh277XBymVCt5plIHwEc8xj46wRGJpga3Sjs4sy6kfIpA290VrN3LH/EIB6HsXBv0U+fH4QDaN vKgLql+j4T6g== X-IronPort-AV: E=Sophos;i="5.79,398,1602572400"; d="scan'208";a="356063094" Received: from pmehra-mobl.amr.corp.intel.com (HELO [10.255.230.38]) ([10.255.230.38]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2021 07:40:08 -0800 Subject: Re: [PATCH] x86/fpu: Use consistent test for X86_FEATURE_XSAVES To: Borislav Petkov , "Chang S. Bae" , Dave Hansen Cc: x86@kernel.org, luto@kernel.org, mingo@kernel.org, tglx@linutronix.de, len.brown@intel.com, ravi.v.shankar@intel.com, linux-kernel@vger.kernel.org References: <20210203024052.15789-1-chang.seok.bae@intel.com> <20210203112340.GA11823@zn.tnic> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <87e436d0-d2ca-8c28-442b-1b45111b6081@intel.com> Date: Wed, 3 Feb 2021 07:40:07 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210203112340.GA11823@zn.tnic> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/3/21 3:23 AM, Borislav Petkov wrote: >> -/* >> - * 'XSAVES' implies two different things: >> - * 1. saving of supervisor/system state >> - * 2. using the compacted format >> - * >> - * Use this function when dealing with the compacted format so >> - * that it is obvious which aspect of 'XSAVES' is being handled >> - * by the calling code. > @dhansen, are you still hung up on that "obvious aspect" or can we kill > this? I still want the compacted-format handling code to be marked. You can do that with new comments: /* Note: XSAVES always uses compacted format: */ if (boot_cpu_has(X86_FEATURE_XSAVES)) { or, leave it as-is: if (using_compacted_format()) { ... Otherwise, we assume that every human being that looks at this code *KNOWS* that XSAVES==compacted. That's not a great assumption.