Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Feb 2021 16:44:04 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Mihai Carabas <mihai.carabas@oracle.com>
Cc:     linux-kernel@vger.kernel.org, arnd@arndb.de,
        andriy.shevchenko@linux.intel.com, bobo.shaobowang@huawei.com
Subject: Re: [PATCH 1/2] misc/pvpanic: split-up generic and platform
 dependent code
Message-ID: <YBrExCSbFu/SCcpW@kroah.com>
References: <1612363439-26656-1-git-send-email-mihai.carabas@oracle.com>
 <1612363439-26656-2-git-send-email-mihai.carabas@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1612363439-26656-2-git-send-email-mihai.carabas@oracle.com>
Precedence: bulk

On Wed, Feb 03, 2021 at 04:43:58PM +0200, Mihai Carabas wrote:
> Split-up generic and platform dependent code in order to introduce pvpanic pci
> device driver later.

What is "later"?

And did you just create a new driver/module in this change?  Why?
And how did you test?  This new module looks to probably taint the
kernel, correct?

How about doing this at the very least, 2 patches, one to move to the
new directory, and the second to split into two modules.  And of course,
please TEST THIS!

thanks,

greg k-h