Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
CC:     "njavali@marvell.com" <njavali@marvell.com>,
        "GR-QLogic-Storage-Upstream@marvell.com" 
        <GR-QLogic-Storage-Upstream@marvell.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        Martin Petersen <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: Simplify the calculation of variables
Thread-Topic: [PATCH] scsi: qla2xxx: Simplify the calculation of variables
Thread-Index: AQHW+dRuaVnQbX0kw0ye7yBov8j3zapGm1EA
Date:   Wed, 3 Feb 2021 16:13:21 +0000
Message-ID: <59881FC4-7621-4740-A4DE-57FAA5936CDB@oracle.com>
References: <1612319190-111421-1-git-send-email-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <1612319190-111421-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EC2EB6AB30C4A942ADEFB881A579DDCB@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: fb67638f-ce0e-459d-925e-08d8c85ea03c
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2021 16:13:21.2940
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VtT01zXpRxO9C3j0Awz9s3uwHCoNOWSSAEs4mHjXaqi/QFOtKY1Fm+IIAXC7IjWM1+ZiVih6vzLJz3w26ardcR4EbVNbTqKBnwSr6rvB3uA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4683
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9884 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0
 suspectscore=0 spamscore=0 mlxlogscore=999 phishscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2102030098
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9884 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 mlxscore=0 priorityscore=1501 spamscore=0 impostorscore=0 clxscore=1011
 suspectscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102030098
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Feb 2, 2021, at 8:26 PM, Jiapeng Chong <jiapeng.chong@linux.alibaba.co=
m> wrote:
>=20
> Fix the following coccicheck warnings:
>=20
> ./drivers/scsi/qla2xxx/qla_target.c:984:12-14: WARNING !A || A && B is
> equivalent to !A || B.
>=20
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/scsi/qla2xxx/qla_target.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla=
_target.c
> index 0d09480..c48daf5 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -981,8 +981,7 @@ void qlt_free_session_done(struct work_struct *work)
> 			int rc;
>=20
> 			if (!own ||
> -			    (own &&
> -			     (own->iocb.u.isp24.status_subcode =3D=3D ELS_PLOGI))) {
> +			     (own->iocb.u.isp24.status_subcode =3D=3D ELS_PLOGI)) {
> 				rc =3D qla2x00_post_async_logout_work(vha, sess,
> 				    NULL);
> 				if (rc !=3D QLA_SUCCESS)
> --=20
> 1.8.3.1
>=20

Looks Good.=20

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering