Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp426898pxb; Wed, 3 Feb 2021 08:38:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJwiS4tOrUMVnqn5i3qdUDynV64WAnuJAVFvg6Z0uoH63+D/prQ3qaOmICpKROa9hgh5JKDi X-Received: by 2002:a17:906:4451:: with SMTP id i17mr3811838ejp.436.1612370328542; Wed, 03 Feb 2021 08:38:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612370328; cv=none; d=google.com; s=arc-20160816; b=jrqlW94OYncCtCzKGAPwsp7aD0/hX4t/7F/wCxFkH9I8IG8Mjevs8BOoQzL81/TPWk 9E1t7FE4gtE/rl1NgoT3uU5fi8Likj3N2teHOjoXprHG14A7KUzddnC1CaDIPFscz9gI nZTIAfRHEXEoTr8Sro3NEkr9sn3eW1zbX88ZxzEKTAYeMy3VNC+oPjgPiQDkUQmlpsAO TEI8sP0zRBbsGxkOwDDgVbz1V0HOspz2Kz0HeE9aFwu56f375nu0Pxqs4afXbnLXKPJG unKWE3wbZz2cpPEYNeA9vEsnAA28+R76qtdr2sn9k7/PLldcatx0t08/pcT2oMNHrI8U UHkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=jB5LniiJVJBhga+KqtjyHJhSLFg6O06N5hOGcOS8Mo0=; b=khw845zFu/DAJEe9jNPyhMNqcnedQCRDGaUiuKVvbUMvXkHIccHlVStiliOjYVlLyL nD6NUOnoCyV+C3xpeUoDkxa6YdHwy1BT85QDtMOv+keVX2zqk3SDRQmO6JPJrHEJP6ie B/yBE959oOBxpmImXRHzyVhSFQpI2fTO1r+0k5JmG1cxWVAppFJdkXzuOEYwAaG2xHcE Xj1D+RcyPWjaDAF+zf0WOEgiG55C78cM17rA7b+RdOdMYkeZcg8EG3MHifFTWcG8he9+ MlZftuEX58fdigsmpuPYz/2RXYT+W33JdA0ptSof0x//ioBZrjGz8x4e7lAw/uCDYkXg neFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@squareup.com header.s=google header.b=IhCfDX9F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=squareup.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q10si1539550edb.606.2021.02.03.08.38.23; Wed, 03 Feb 2021 08:38:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@squareup.com header.s=google header.b=IhCfDX9F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=squareup.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234516AbhBCQgL (ORCPT + 99 others); Wed, 3 Feb 2021 11:36:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234257AbhBCQfV (ORCPT ); Wed, 3 Feb 2021 11:35:21 -0500 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D27D1C061793 for ; Wed, 3 Feb 2021 08:34:40 -0800 (PST) Received: by mail-pg1-x52d.google.com with SMTP id v19so51668pgj.12 for ; Wed, 03 Feb 2021 08:34:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=squareup.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jB5LniiJVJBhga+KqtjyHJhSLFg6O06N5hOGcOS8Mo0=; b=IhCfDX9FMqbywbKhoTeq5CpvYQa1Psp9hJuE1uJrOqwkKrhrrvWmMoe8m6iol0kbps HxbaRc17fVXZpZyPm77VCnP4cOecqSZ9x4wyiFpM6WHPC344z/eB/OYcCILta/N1CMor Siz04H8TaB1YW00cQ/gGUN7LfU1PPhOMAtZw0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jB5LniiJVJBhga+KqtjyHJhSLFg6O06N5hOGcOS8Mo0=; b=IzQ0jXdQeIM5p/e7e4h1qAqMWlhHyFbObyoHhxOQ3iKCDiZq2YE5EbiOkwmBm7+0cq fWF6lPmlqWwvceNwx8CDKpOtE9boWWjQoYJEApUO5s2S4hNRsWKHnusGtnO/QRIld6sj JMXAwhS22AS1ytj37lhB4+koLesC32eh+aXvfs+njhzzFoXpyFToDtz4ZWky7WYJJ5G4 Ogney0hfuixISPzu3RvkOVKCrovNQs74jvAOA9QCM49UoWGM1LnrwbuIYl4zW4ha+yoN xWvUaJZatzSTsf74XvQlLsoUxvwfaNBUHjE10fbFMiglQUfkpS6rZr38F94fFjHV+CxA 6DQg== X-Gm-Message-State: AOAM533C4NlexZBTP7yHrcfcj30noDAgBnmchLl2jOEkO1gp1hJqQ9qb lAjtuBSltS3NGS0q5gFTVlyopg== X-Received: by 2002:a63:fe05:: with SMTP id p5mr4446854pgh.161.1612370080390; Wed, 03 Feb 2021 08:34:40 -0800 (PST) Received: from localhost (162-207-206-139.lightspeed.sntcca.sbcglobal.net. [162.207.206.139]) by smtp.gmail.com with ESMTPSA id p2sm2620288pjj.0.2021.02.03.08.34.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Feb 2021 08:34:39 -0800 (PST) From: Benjamin Li To: Georgi Djakov Cc: square@linaro.org, kernel@squareup.com, Benjamin Li , Andy Gross , Bjorn Andersson , Georgi Djakov , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] interconnect: qcom: msm8939: remove rpm-ids from non-RPM nodes Date: Wed, 3 Feb 2021 08:34:07 -0800 Message-Id: <20210203163407.9222-3-benl@squareup.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210203163407.9222-1-benl@squareup.com> References: <20210203163407.9222-1-benl@squareup.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changes corresponding to commit c497f9322af9 ("interconnect: qcom: msm8916: Remove rpm-ids from non-RPM nodes") to remove this log spam on 8939: [ 1.901376] qcom_icc_rpm_smd_send slv 24 error -6 [ 2.005977] qcom_icc_rpm_smd_send mas 20 error -6 [ 2.010250] qcom_icc_rpm_smd_send slv 20 error -6 [ 2.014684] qcom_icc_rpm_smd_send slv 106 error -6 [ 2.019338] qcom_icc_rpm_smd_send slv 107 error -6 [ 2.024615] qcom_icc_rpm_smd_send slv 29 error -6 [ 2.028782] qcom_icc_rpm_smd_send mas 3 error -6 [ 2.034657] qcom_icc_rpm_smd_send mas 100 error -6 (plus another slv 131 that's hidden by the mas 100 failure) Signed-off-by: Benjamin Li --- drivers/interconnect/qcom/msm8939.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/interconnect/qcom/msm8939.c b/drivers/interconnect/qcom/msm8939.c index dfbec30ed149..20f31a1b4192 100644 --- a/drivers/interconnect/qcom/msm8939.c +++ b/drivers/interconnect/qcom/msm8939.c @@ -131,7 +131,7 @@ DEFINE_QNODE(mas_pcnoc_sdcc_1, MSM8939_MASTER_SDCC_1, 8, -1, -1, MSM8939_PNOC_IN DEFINE_QNODE(mas_pcnoc_sdcc_2, MSM8939_MASTER_SDCC_2, 8, -1, -1, MSM8939_PNOC_INT_1); DEFINE_QNODE(mas_qdss_bam, MSM8939_MASTER_QDSS_BAM, 8, -1, -1, MSM8939_SNOC_QDSS_INT); DEFINE_QNODE(mas_qdss_etr, MSM8939_MASTER_QDSS_ETR, 8, -1, -1, MSM8939_SNOC_QDSS_INT); -DEFINE_QNODE(mas_snoc_cfg, MSM8939_MASTER_SNOC_CFG, 4, 20, -1, MSM8939_SLAVE_SRVC_SNOC); +DEFINE_QNODE(mas_snoc_cfg, MSM8939_MASTER_SNOC_CFG, 4, -1, -1, MSM8939_SLAVE_SRVC_SNOC); DEFINE_QNODE(mas_spdm, MSM8939_MASTER_SPDM, 4, -1, -1, MSM8939_PNOC_MAS_0); DEFINE_QNODE(mas_tcu0, MSM8939_MASTER_TCU0, 16, -1, -1, MSM8939_SLAVE_EBI_CH0, MSM8939_BIMC_SNOC_MAS, MSM8939_SLAVE_AMPSS_L2); DEFINE_QNODE(mas_usb_hs1, MSM8939_MASTER_USB_HS1, 4, -1, -1, MSM8939_PNOC_MAS_1); @@ -156,14 +156,14 @@ DEFINE_QNODE(pcnoc_snoc_mas, MSM8939_PNOC_SNOC_MAS, 8, 29, -1, MSM8939_PNOC_SNOC DEFINE_QNODE(pcnoc_snoc_slv, MSM8939_PNOC_SNOC_SLV, 8, -1, 45, MSM8939_SNOC_INT_0, MSM8939_SNOC_INT_BIMC, MSM8939_SNOC_INT_1); DEFINE_QNODE(qdss_int, MSM8939_SNOC_QDSS_INT, 8, -1, -1, MSM8939_SNOC_INT_0, MSM8939_SNOC_INT_BIMC); DEFINE_QNODE(slv_apps_l2, MSM8939_SLAVE_AMPSS_L2, 16, -1, -1, 0); -DEFINE_QNODE(slv_apss, MSM8939_SLAVE_APSS, 4, -1, 20, 0); +DEFINE_QNODE(slv_apss, MSM8939_SLAVE_APSS, 4, -1, -1, 0); DEFINE_QNODE(slv_audio, MSM8939_SLAVE_LPASS, 4, -1, -1, 0); DEFINE_QNODE(slv_bimc_cfg, MSM8939_SLAVE_BIMC_CFG, 4, -1, -1, 0); DEFINE_QNODE(slv_blsp_1, MSM8939_SLAVE_BLSP_1, 4, -1, -1, 0); DEFINE_QNODE(slv_boot_rom, MSM8939_SLAVE_BOOT_ROM, 4, -1, -1, 0); DEFINE_QNODE(slv_camera_cfg, MSM8939_SLAVE_CAMERA_CFG, 4, -1, -1, 0); -DEFINE_QNODE(slv_cats_0, MSM8939_SLAVE_CATS_128, 16, -1, 106, 0); -DEFINE_QNODE(slv_cats_1, MSM8939_SLAVE_OCMEM_64, 8, -1, 107, 0); +DEFINE_QNODE(slv_cats_0, MSM8939_SLAVE_CATS_128, 16, -1, -1, 0); +DEFINE_QNODE(slv_cats_1, MSM8939_SLAVE_OCMEM_64, 8, -1, -1, 0); DEFINE_QNODE(slv_clk_ctl, MSM8939_SLAVE_CLK_CTL, 4, -1, -1, 0); DEFINE_QNODE(slv_crypto_0_cfg, MSM8939_SLAVE_CRYPTO_0_CFG, 4, -1, -1, 0); DEFINE_QNODE(slv_dehr_cfg, MSM8939_SLAVE_DEHR_CFG, 4, -1, -1, 0); @@ -187,20 +187,20 @@ DEFINE_QNODE(slv_sdcc_2, MSM8939_SLAVE_SDCC_2, 4, -1, -1, 0); DEFINE_QNODE(slv_security, MSM8939_SLAVE_SECURITY, 4, -1, -1, 0); DEFINE_QNODE(slv_snoc_cfg, MSM8939_SLAVE_SNOC_CFG, 4, -1, -1, 0); DEFINE_QNODE(slv_spdm, MSM8939_SLAVE_SPDM, 4, -1, -1, 0); -DEFINE_QNODE(slv_srvc_snoc, MSM8939_SLAVE_SRVC_SNOC, 8, -1, 29, 0); +DEFINE_QNODE(slv_srvc_snoc, MSM8939_SLAVE_SRVC_SNOC, 8, -1, -1, 0); DEFINE_QNODE(slv_tcsr, MSM8939_SLAVE_TCSR, 4, -1, -1, 0); DEFINE_QNODE(slv_tlmm, MSM8939_SLAVE_TLMM, 4, -1, -1, 0); DEFINE_QNODE(slv_usb_hs1, MSM8939_SLAVE_USB_HS1, 4, -1, -1, 0); DEFINE_QNODE(slv_usb_hs2, MSM8939_SLAVE_USB_HS2, 4, -1, -1, 0); DEFINE_QNODE(slv_venus_cfg, MSM8939_SLAVE_VENUS_CFG, 4, -1, -1, 0); -DEFINE_QNODE(snoc_bimc_0_mas, MSM8939_SNOC_BIMC_0_MAS, 16, 3, -1, MSM8939_SNOC_BIMC_0_SLV); -DEFINE_QNODE(snoc_bimc_0_slv, MSM8939_SNOC_BIMC_0_SLV, 16, -1, 24, MSM8939_SLAVE_EBI_CH0); +DEFINE_QNODE(snoc_bimc_0_mas, MSM8939_SNOC_BIMC_0_MAS, 16, -1, -1, MSM8939_SNOC_BIMC_0_SLV); +DEFINE_QNODE(snoc_bimc_0_slv, MSM8939_SNOC_BIMC_0_SLV, 16, -1, -1, MSM8939_SLAVE_EBI_CH0); DEFINE_QNODE(snoc_bimc_1_mas, MSM8939_SNOC_BIMC_1_MAS, 16, 76, -1, MSM8939_SNOC_BIMC_1_SLV); DEFINE_QNODE(snoc_bimc_1_slv, MSM8939_SNOC_BIMC_1_SLV, 16, -1, 104, MSM8939_SLAVE_EBI_CH0); DEFINE_QNODE(snoc_bimc_2_mas, MSM8939_SNOC_BIMC_2_MAS, 16, -1, -1, MSM8939_SNOC_BIMC_2_SLV); DEFINE_QNODE(snoc_bimc_2_slv, MSM8939_SNOC_BIMC_2_SLV, 16, -1, -1, MSM8939_SLAVE_EBI_CH0); DEFINE_QNODE(snoc_int_0, MSM8939_SNOC_INT_0, 8, 99, 130, MSM8939_SLAVE_QDSS_STM, MSM8939_SLAVE_IMEM, MSM8939_SNOC_PNOC_MAS); -DEFINE_QNODE(snoc_int_1, MSM8939_SNOC_INT_1, 8, 100, 131, MSM8939_SLAVE_APSS, MSM8939_SLAVE_CATS_128, MSM8939_SLAVE_OCMEM_64); +DEFINE_QNODE(snoc_int_1, MSM8939_SNOC_INT_1, 8, -1, -1, MSM8939_SLAVE_APSS, MSM8939_SLAVE_CATS_128, MSM8939_SLAVE_OCMEM_64); DEFINE_QNODE(snoc_int_bimc, MSM8939_SNOC_INT_BIMC, 8, 101, 132, MSM8939_SNOC_BIMC_1_MAS); DEFINE_QNODE(snoc_pcnoc_mas, MSM8939_SNOC_PNOC_MAS, 8, -1, -1, MSM8939_SNOC_PNOC_SLV); DEFINE_QNODE(snoc_pcnoc_slv, MSM8939_SNOC_PNOC_SLV, 8, -1, -1, MSM8939_PNOC_INT_0); -- 2.17.1