Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp428781pxb; Wed, 3 Feb 2021 08:41:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJx80255qaU3h9eJ5F/xWal32Y1np4A98NJaPr8srJJyTOrNsAuO9mJyG+7mdk1IhSEzThsk X-Received: by 2002:a05:6402:34c1:: with SMTP id w1mr3935059edc.147.1612370477290; Wed, 03 Feb 2021 08:41:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612370477; cv=none; d=google.com; s=arc-20160816; b=O2jUAnz9ikTW+LH1FQ6oeH/smLMdDunkRVXOdmgkcoUzcWOKzodTcWygACsbugnXJA kcWKkCU8JB2FB55OabIaFNgT6TFjN0foyqI7cQFxRbTBjTOF75uhZTKkrzutnYc3bN1M 3AbEiyqilOg4hXD9VlgEmYHrPB4MFQMJnYQi5jX0NzEZMhpuoSZBwKBV1pEpTMdVFzM1 3ct05MBBvvd4dF6wSxMFN0y10ulFirWGrczBC8ZnJ1X/BlFk2bxAvW2n1MkyYNZhZUs1 33fdPaY/w/xHDvDwCOuugT5cS8Kgbn219cdlwid+gDncdea9KlMPBcsard7qdRON1o0l SkyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=zQtOgbB7m+FsmzB3eiYRAsuKyqGMXV7NH2ngyTbUPaU=; b=ImU/OQIrAr/e0WwwY4D7jxmn3iAxZM3IUgdWfWb1Bma1i+CpJsPW7LPjAUHY2opK05 wVO3Xd8zY5PIstMDfNuMH0uHwQlUCWR7glOEyXNaWNHoOKcuOAup4+EGyzNid1yAdwEc YaqJNgZ521GU1LUIDnu3mJZNxp5AspDLNJZFejemdh5hHvpNk6qyYNQr3w9zeXMRUClW Uyn562F67wEuxb9hX9pJaSWMNoWuxmCOyjMVRvEiniRHxowz/pSF1qT566Za5Y+PgzpR skPnrpPSThM3DRJzsIjId+b0+lVdBpFuByKLzMAy8073yvDXMbDYUDcbGDtPUsfDhRAf Yqyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=OBHf5LoD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kl7si1756755ejc.308.2021.02.03.08.40.51; Wed, 03 Feb 2021 08:41:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=OBHf5LoD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229579AbhBCQkR (ORCPT + 99 others); Wed, 3 Feb 2021 11:40:17 -0500 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:7299 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbhBCQjv (ORCPT ); Wed, 3 Feb 2021 11:39:51 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 03 Feb 2021 08:39:11 -0800 Received: from [10.25.102.154] (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 3 Feb 2021 16:39:07 +0000 Subject: Re: Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function To: Mark Brown CC: , , , , , , References: <1612368575-25991-1-git-send-email-spujar@nvidia.com> <1612368575-25991-2-git-send-email-spujar@nvidia.com> <20210203161951.GG4880@sirena.org.uk> From: Sameer Pujar Message-ID: <64b65aaf-9971-e071-5d52-02286fe0cacc@nvidia.com> Date: Wed, 3 Feb 2021 22:09:01 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210203161951.GG4880@sirena.org.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1612370351; bh=zQtOgbB7m+FsmzB3eiYRAsuKyqGMXV7NH2ngyTbUPaU=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding: Content-Language:X-Originating-IP:X-ClientProxiedBy; b=OBHf5LoDGB/RlsY1s91yGCrRul3cssQmvkcJ0iSmrPdKXCagz9WdoHVssV1AB+TNH B/9yzmTSfJ0Z5u7D5ajEps+e6BM0zQyN0tgEGpCAaYqfj7eUG6trxM06w8B2NBudXA kfnkDFOR+dhi9h0Keq+U1Xw7qxo39xnN3CrNqRz9Nb9gx5182jg8G7SJQ7+1NuGZxq 9LN92l1jjRasxlLWpNR0fBSAxuW8eT5JWm8kcNISi8kRuQC9HaHouIVXEVUR4sH5Jo QfLoUw0FH4R5nOR4zToO8DxTDtIhTZbovaarMTLyclnsdg9oV/XSuWBgAzUs59rmQo 0qj/aS3UWakHA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/3/2021 9:49 PM, Mark Brown wrote: > On Wed, Feb 03, 2021 at 09:39:34PM +0530, Sameer Pujar wrote: > >> +int graph_remove(struct platform_device *pdev); > I think this needs better namespacing if it's going to be exported. audio_graph_remove() can be a better choice?