Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Kostya Porotchkin <kostap@marvell.com>
To:     Russell King - ARM Linux admin <linux@armlinux.org.uk>
CC:     Baruch Siach <baruch@tkos.co.il>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "jaz@semihalf.com" <jaz@semihalf.com>,
        "gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
        Nadav Haklai <nadavh@marvell.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        Stefan Chulski <stefanc@marvell.com>,
        "mw@semihalf.com" <mw@semihalf.com>,
        Ben Peled <bpeled@marvell.com>,
        "sebastian.hesselbarth@gmail.com" <sebastian.hesselbarth@gmail.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI
 settings
Thread-Topic: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI
 settings
Thread-Index: AQHW+jD04fJzej2FY0aIGyOLdCg1f6pGdPSAgAAJqBCAAAGXAIAAAY2wgAAYXgCAAAmuIA==
Date:   Wed, 3 Feb 2021 16:57:09 +0000
Message-ID: <DM5PR18MB14525D61BC500B0026F30D07CAB49@DM5PR18MB1452.namprd18.prod.outlook.com>
References: <20210203133138.10754-1-kostap@marvell.com>
 <20210203133138.10754-3-kostap@marvell.com> <87h7mtckxe.fsf@tarshish>
 <DM5PR18MB14529A28A31785A574A4DEF5CAB49@DM5PR18MB1452.namprd18.prod.outlook.com>
 <20210203143851.GR1463@shell.armlinux.org.uk>
 <DM5PR18MB1452A6CF26E3A54730872A14CAB49@DM5PR18MB1452.namprd18.prod.outlook.com>
 <20210203161137.GS1463@shell.armlinux.org.uk>
In-Reply-To: <20210203161137.GS1463@shell.armlinux.org.uk>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e5af82a7-a377-4518-7b5b-08d8c864bef8
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2021 16:57:09.7756
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Gbx0mPhZsswYbfAKXn7KoqIbbscD1J5eJQB/aZMlJpZJNYzz7KCYgdYnqqjkp85YDSAyOgp9ayDLa3pTLrWAXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB0938
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737
 definitions=2021-02-03_06:2021-02-03,2021-02-03 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello, Russell,
I agree that this patch needs rework.
I will definitely do it and issue a new version.

> On Wed, Feb 03, 2021 at 02:50:45PM +0000, Kostya Porotchkin wrote:
> > [KP] So for older systems this "slow mode" parameter could be set on th=
e
> board level.
> > When it is set in ap80x,dtsi file it downgrades all systems to HS-SDR52=
, even
> if they support HS400 on AP side.
> > MacchiatoBIN AP eMMC is connected to 3.3v regulator and has "no-1-8-v"
> flag set, so it should remain in low speed anyway.
>=20
> Your reasoning does not make sense.
>=20
> The ap80x.dtsi file does not specify "marvell,xenon-phy-slow-mode".
> It is not specified at this level. It is already specified at board level=
.
[KP] it does. In current armada-ap80x.dtsi File this specification is on ro=
w 260:
			ap_sdhci0: sdhci@6e0000 {
				compatible =3D "marvell,armada-ap806-sdhci";
				reg =3D <0x6e0000 0x300>;
				interrupts =3D <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
				clock-names =3D "core";
				clocks =3D <&ap_clk 4>;
				dma-coherent;
				marvell,xenon-phy-slow-mode;
				status =3D "disabled";
			};
So I would like to remove this row.
=20
> Given that Macchiatobin will still use slow mode, why remove the
> marvell,xenon-phy-slow-mode property from this file?
[KP] Agree, I will keep this property in Macchiatobin DTS file.

>=20
> Also, if you're upgrading ap80x.dtsi to use a bus-width of 8, why keep th=
e bus-
> width specifier of 8 in the board files?
[KP] The bus width is updated in A8040 DB DTS. This board utilizes 8-bit in=
terface.
The armada-ap80x.dtsi file does not specifies the bus width since it is boa=
rd-specific.

>=20
> This patch just doesn't make sense, and your responses to our points seem=
 to
> add to the confusion.
[KP] I am sorry about it. Hope my last response clarifies it.

Kosta
>=20
> --
> RMK's Patch system: https://urldefense.proofpoint.com/v2/url?u=3Dhttps-
> 3A__www.armlinux.org.uk_developer_patches_&d=3DDwIBAg&c=3DnKjWec2b6R0
> mOyPaz7xtfQ&r=3D-
> N9sN4p5NSr0JGQoQ_2UCOgAqajG99W1EbSOww0WU8o&m=3DV27OOcgNqKN2
> WrlW2YFvHm_D_dXoP44wPd5zyOKvEBk&s=3Do3OrmStt1ZuXVNlYklTV_b1wY35
> NvPPrdLqwGgtxRZU&e=3D
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!