Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] misc/pvpanic: split-up generic and platform dependent
 code
To:     Mihai Carabas <mihai.carabas@oracle.com>,
        linux-kernel@vger.kernel.org
Cc:     gregkh@linuxfoundation.org, arnd@arndb.de,
        andriy.shevchenko@linux.intel.com, bobo.shaobowang@huawei.com
References: <1612363439-26656-1-git-send-email-mihai.carabas@oracle.com>
 <1612363439-26656-2-git-send-email-mihai.carabas@oracle.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <9080b512-33a8-e9f9-7c4c-bc2572ab7e5c@infradead.org>
Date:   Wed, 3 Feb 2021 09:13:39 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <1612363439-26656-2-git-send-email-mihai.carabas@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/3/21 6:43 AM, Mihai Carabas wrote:
> diff --git a/drivers/misc/pvpanic/Kconfig b/drivers/misc/pvpanic/Kconfig
> new file mode 100644
> index 00000000..12bb017
> --- /dev/null
> +++ b/drivers/misc/pvpanic/Kconfig
> @@ -0,0 +1,14 @@
> +config PVPANIC
> +	bool "pvpanic device support"
> +	depends on PVPANIC_MMIO
> +	help
> +	  This option enable generic code for pvpanic device driver logic.
> +
> +config PVPANIC_MMIO
> +	tristate "pvpanic mmio device support"

	                  MMIO


Also capitalize PCI in the other patch in the similar location.

> +	depends on HAS_IOMEM && (ACPI || OF)
> +	select PVPANIC
> +	help
> +	  This driver provides support for the pvpanic device.  pvpanic is
> +	  a paravirtualized device provided by QEMU; it lets a virtual machine
> +	  (guest) communicate panic events to the host.


thanks.
-- 
~Randy