Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp464938pxb; Wed, 3 Feb 2021 09:27:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1nhfW3AlWB3w7QpLiXY2dKh8Pr1WIcUCELa/rvIScIghS7ZSsewBwfL2aTAzxB+SlJb4x X-Received: by 2002:a50:a6ce:: with SMTP id f14mr4097492edc.346.1612373269617; Wed, 03 Feb 2021 09:27:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612373269; cv=none; d=google.com; s=arc-20160816; b=gp8LR23iKOTMfxTaUVI+uT1UNmzm6DZCT7UpAlc+JvQ6wnzRCPRM7dfCYsgTnjFVRK oPzfyRWiC5DiBJ+81ZOM0rg8+EiA/fTKPl8Cx8IS+dOChI/XvPaGNuqbjQumpr5CEDRc 1MIOhzTnpfroXz/Bg4ot053I8HKhQhyKYy/qiiSTLVst8vTKiv8paVXuF4EMK31WObA1 6nS7nepIU8RHgjKnM9cHGgxjj7/QyJ9jtkiLXpvFOYETQBDQYkC9PNTY0Y0t5E6clC5A vmmE80TjlgyIwG8KuSrTl9BbyGnwcO65IImQuMvxGSWif+c/+TAMwEmtAZgF0K1umDrL O+qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=DYbEj7cptRBApqWUKkh6JYd7TnHMIjdi2tFe+gIpVwI=; b=qy/ltdT6Qrc/5XCOw0CM/GH50aLohi3G2rxZblHKavValTRvoT5riLmB+CjZbqAYqp iQQ1OHy0XlbXPuu99YMWrQDNChXfh9IsZlWd3JNNTbsuwz1y3rAqUmU/2JPnWmyMPV5O 7TG89ig4TKAd40r9T4Yz4SBxl7qVEaWe62uuzntrqQrQt7KzTgQDLX+vKwZ4Kc1SqDFf 1NDAx7Yd5k80k6iiHVA4kwqor9sFpUbnkaNAqtV9xzSUnAUnPsxDdPR/5VXJU0RpbgRL Ok9rG6r0yAt5x20zPzHocVjca3LSCbPVLIof8wTLxinuuPQb6fw8U/MhPZhXisb7gcD8 OHZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n25si1708486eja.737.2021.02.03.09.27.23; Wed, 03 Feb 2021 09:27:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232399AbhBCR0u (ORCPT + 99 others); Wed, 3 Feb 2021 12:26:50 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:56682 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232415AbhBCR0F (ORCPT ); Wed, 3 Feb 2021 12:26:05 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 7D6E11C0B9C; Wed, 3 Feb 2021 18:25:08 +0100 (CET) Date: Wed, 3 Feb 2021 18:25:08 +0100 From: Pavel Machek To: Sven Schuchmann Cc: Dan Murphy , Rob Herring , "linux-leds@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1] leds: lp50xx: add setting of default intensity from DT Message-ID: <20210203172508.GC23019@duo.ucw.cz> References: <20210119105312.2636-1-schuchmann@schleissheimer.de> <20210203142940.GB12369@duo.ucw.cz> <20210203163555.GA23019@duo.ucw.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nmemrqcdn5VTmUEE" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nmemrqcdn5VTmUEE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > Yes, sounds reasonable. Could we get default intensity of 100% on all > > channels if nothing else is specified? > >=20 > > Or maybe simply "if intensity is not specified, start with 100%, and > > use explicit =3D0 if other color is expected". > >=20 > Mh, if someone is already using the led driver and updates to a newer ker= nel=20 > we would then turn on all leds per default to the maximum intensity durin= g boot=20 > until they are set the way they should be from userspace. I don't know if= this > is what we want? If yes, sure, we could set them to maximum per > default. Not really. If they don't have trigger configured, nothing will happen. > Also if we want to use Percentage Values (%) for setting the intensity > I think this should also be done for the userspace interfaces and > not only from DT. We don't want to use percentages in the API (but let me still use percentages in discussion). Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --nmemrqcdn5VTmUEE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYBrcdAAKCRAw5/Bqldv6 8jkUAJwNJ0tMFMEhlguq/D6XwEq0NqqDEgCgv9kRAIWGuBErh1lbV1J4F3uWhqI= =3Fgp -----END PGP SIGNATURE----- --nmemrqcdn5VTmUEE--