Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp466878pxb; Wed, 3 Feb 2021 09:30:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwenC6/wKAb6UQ6qSPaMYnj8UhMQI3+F/8F5k6PoM0psl1/9p5XnDEe8LuDpQQRgwhRymoC X-Received: by 2002:aa7:ce15:: with SMTP id d21mr4222038edv.246.1612373423430; Wed, 03 Feb 2021 09:30:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612373423; cv=none; d=google.com; s=arc-20160816; b=z6nuPpJmLFEiWs72/vBZMRB7COAH+1PjuUZJ7erF4rV1Mo005FgN6ZGej4C5IhzPgV yNBSPImZk4RjX5rtzOnW7Sx6S2THYd2PwRy5ooy5gEsJcuE7akA3JvmsnnjMuB1D/hFQ IO+GqkKIDPm0Qv+Z7K08bljkW1lSXnnsZJhG7ndJFc6y6AlkDKcmfHvqn/KUEKIZ9xv5 S1LyqI4bZnq3g6n066E9fjzf1lYxMGxDjWL/R7j3Uecoa+Hd6FFDuH5cn8MzB/QopERt kCsVgyc/fXWdcxrnQyvwcSoV2xihc4jCmMJ3vtYA+pjPAAPqW34OBR5YDHs6rsWkLkOg 67XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=/yhI2spPcVGMBVmOZvUkwECDxBhVNdZcA9Cpql60alQ=; b=ZkB97jR9Ukr7CC3RZaHO/13pzmCdYSJxzXpCpAf3sKYBItV2ElK/8WDOhyFuQAmTpA sMOp4t4sRr4mAd7T7Esfg7esOUiM6Ajj2wAmP9DWI/B49PAXyVwbtELnN/XpPML5DNGQ KWs/lgwDNo6gFzwXlEUcoBFZxEpT0dz2eof462HDVOXZk1Rl5MMOgvWOp23ccfngPSqz QVP00GXc/GU3NFXIUPagLIznMxllZCpuhMe6lLslwF0VRR6ABadFGHEG1WnqMFDqODJ3 rOj+5ogFY6RZqjqtUVGFp84ryRDCPL3D+jg3qjVilzIB3Lwv3V5F7xwWqpUndcmjdS6i L7qA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q5Psc9RE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ox26si1333528ejb.209.2021.02.03.09.29.55; Wed, 03 Feb 2021 09:30:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q5Psc9RE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232131AbhBCR02 (ORCPT + 99 others); Wed, 3 Feb 2021 12:26:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:47570 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232116AbhBCRZo (ORCPT ); Wed, 3 Feb 2021 12:25:44 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0B16764F68; Wed, 3 Feb 2021 17:25:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612373104; bh=/yhI2spPcVGMBVmOZvUkwECDxBhVNdZcA9Cpql60alQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q5Psc9RErW69hu2Tr1n6s+KkTUj4xSf0zHcNvDJdxOyrw2F+Ipb905Dw68xwg+Dgc MEV6TVp32DMji47F1WpFteX8ZGBp1IGmR618GmlHPSrzDCYEkiftCGGJrSv0G27gN7 A9QHaPGatDcFj+TvMcu19I/IEb+Ir6zRkuXUSgJScgaIbS7pKL2C4Er1G4c8vTrC9n C676XaaTFguU4XtUWtn1fWuiVSmw7RVsZLByOKsuwhkjiMv6hUC9GE1BC/lZv6ao8y ZhTt2fUOJ/l3dIieaH9J1oc9yMqPzu1Y5ctN9/LaFRZw+387zMPWzuow+pTOPdr8EX tehoZ7/GrxRSg== Date: Wed, 3 Feb 2021 17:24:15 +0000 From: Mark Brown To: Sameer Pujar Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, kuninori.morimoto.gx@renesas.com, alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, sharadg@nvidia.com Subject: Re: Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function Message-ID: <20210203172415.GH4880@sirena.org.uk> References: <1612368575-25991-1-git-send-email-spujar@nvidia.com> <1612368575-25991-2-git-send-email-spujar@nvidia.com> <20210203161951.GG4880@sirena.org.uk> <64b65aaf-9971-e071-5d52-02286fe0cacc@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZYOWEO2dMm2Af3e3" Content-Disposition: inline In-Reply-To: <64b65aaf-9971-e071-5d52-02286fe0cacc@nvidia.com> X-Cookie: Who was that masked man? User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ZYOWEO2dMm2Af3e3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 03, 2021 at 10:09:01PM +0530, Sameer Pujar wrote: > On 2/3/2021 9:49 PM, Mark Brown wrote: > > On Wed, Feb 03, 2021 at 09:39:34PM +0530, Sameer Pujar wrote: > > > +int graph_remove(struct platform_device *pdev); > > I think this needs better namespacing if it's going to be exported. > audio_graph_remove() can be a better choice? Yeah, that looks reasonable. --ZYOWEO2dMm2Af3e3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmAa3D8ACgkQJNaLcl1U h9DgsQf9GzN3MtpiKxC9z9VC6D/VDCcjNVKfBH4n8AsORm22h3JUl7Y5j1VQE1aO feY09SDZ/Xyfu868hB3PC2NhljwRUkkA0s8gnCTMvgprT08OjHZDqzi0nQd2Z0BH 2V5vO7RgGB0jFXEWwIvFM0AqtcufWjUUDKnlbVGSi/rbOrQCiT6zoUC3BJmGmQLP DVPeklIGLqLzbwu+OkWzp0ZImxtonyE07PDnuek2MaH/41HoBRbPRrzfgREgzTt3 +QSL8GQecG+2Ia0+4LnCy7g528weLNEFB7HDBtqx4SGMct1lD7xhWTPM89sxNq65 fIRzGZOE8p1RYsstGe04kKxpHBxB4g== =qMSx -----END PGP SIGNATURE----- --ZYOWEO2dMm2Af3e3--