Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp487277pxb; Wed, 3 Feb 2021 10:01:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJyyTiddSIePa1krFv0OtZRXZarmPLRtV+n/00u9MO6BQ2KDPRsd9LOEk+DjSlr6GeMM2dnY X-Received: by 2002:a5d:4292:: with SMTP id k18mr4944039wrq.218.1612375302645; Wed, 03 Feb 2021 10:01:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612375302; cv=none; d=google.com; s=arc-20160816; b=AzIG3W2GLMPV2MjstwI/SO3EGRSSt1IVMxoMWPaczaqLv039QipetAq1wmDAgwyrYt 7n4XVSc8q0nv0G5Tc2R6wYuZYJGs7iDq0k5+rHnMB/w5Bw84lpy7vqOpsyuqNAwH+SHh fSGBao+S0DS5bDxCLqmwTAMYHIkotzGj2ZVvqTauHcrWegCByuaEBnh7mvKr2rNQX6i7 fyV7rsxN6zcJHEEh/imB5wej4HMzSLWl4PASuIqStdA7DEV6uKHM1/fVVTEzhgK+kZWk X3En977ayg0hV1H8jhNEWiTjxaNCoRr0M3WG5PaOdeC8igviZ/9YU/24TEKNM3fjp5JD k5MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:references:in-reply-to :message-id:date:subject:to:from:dkim-signature; bh=pCyObRoYs4TuqGUabO/rMbP3htemyH/3g4S6VzT5G0o=; b=wdM/rI83vTCSKXtdBS7nw8IXKRpnkZaJTIZHYIIH7yqUSB1PJThNkCkYGo5NihbxeP zO18zAk77+dpa1hxqep9qF2FXZT8JT1FFm0C9s7F5E5YMf1zntmWnnOMDX+9gB7d33I1 k1Kxm8i2QkXdjCnWUTMZF9Hy/AN6TD1ZE785gOB1S88kxegflUDgO1ezVOI3OfF13hmx ZbE+JBW4ecdc82L2YrJ7uiudMUwVoRL927KwvKnC8XlMwQ86osAk+KCClr3eDqTgHoi1 L2Il3iIVle3FVFqpevjw9plB9rKkbpEfXIckdfez48WNy62pU/jwU9bus8AH3iNikdiu f7UQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=ltqKhfPt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o11si1788553ejn.707.2021.02.03.10.01.16; Wed, 03 Feb 2021 10:01:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=ltqKhfPt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230355AbhBCR73 (ORCPT + 99 others); Wed, 3 Feb 2021 12:59:29 -0500 Received: from smtprelay-out1.synopsys.com ([149.117.87.133]:40818 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232479AbhBCR6b (ORCPT ); Wed, 3 Feb 2021 12:58:31 -0500 Received: from mailhost.synopsys.com (mdc-mailhost2.synopsys.com [10.225.0.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 739BAC010E; Wed, 3 Feb 2021 17:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1612375050; bh=RPtJq9pnB6c2RL81eMcBv6mkc0ffZocP1N1iwYCqspQ=; h=From:To:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=ltqKhfPtIAlvAZMklZE/yTPmeeoq5TR+HfJkqtVKFf0P6+EzM9RQaeS+i8HV3DaBt LZKerbANIRg+pEzjmUiFgFET49X2lsimIsQLKP9sEvNbnI0cYt1+dNXt9w8iu6cPb8 5KDhRaqUeAt+r2PoBpNG2cS/CgCPKOSLg9LJPiTZiVjfRUoCflPiqX0v6Tk2zWod2X avM0MSl2ltAKn5DjCcit9EzOmmYDymBlo0BuZjeZB0qbIFH3GmKRHC/w+avJJjNLz0 yFB/lQcKE0UkO9vFWF/Jz9nkRgLGQ3joF5yITY/O8FUDqwxUfDry7VPhIFQ0OQoq/X lx4yCKJvZd3RA== Received: from de02dwia024.internal.synopsys.com (de02dwia024.internal.synopsys.com [10.225.19.81]) by mailhost.synopsys.com (Postfix) with ESMTP id 3888DA005E; Wed, 3 Feb 2021 17:57:29 +0000 (UTC) X-SNPS-Relay: synopsys.com From: Gustavo Pimentel To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Vinod Koul , Dan Williams , Bjorn Helgaas , Gustavo Pimentel Subject: [PATCH v3 15/15] dmaengine: dw-edma: Add pcim_iomap_table return checker Date: Wed, 3 Feb 2021 18:57:07 +0100 Message-Id: <9fcd7137c661d1a5e6b8e6441de7e903e2cfc069.1612374941.git.gustavo.pimentel@synopsys.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Detected by CoverityScan CID 16555 ("Dereference null return") Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c index 686b4ff..7445033 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -238,6 +238,9 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, dw->rd_ch_cnt = vsec_data.rd_ch_cnt; dw->rg_region.vaddr = pcim_iomap_table(pdev)[vsec_data.rg.bar]; + if (!dw->rg_region.vaddr) + return -ENOMEM; + dw->rg_region.vaddr += vsec_data.rg.off; dw->rg_region.paddr = pdev->resource[vsec_data.rg.bar].start; dw->rg_region.paddr += vsec_data.rg.off; @@ -250,12 +253,18 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, struct dw_edma_block *dt_block = &vsec_data.dt_wr[i]; ll_region->vaddr = pcim_iomap_table(pdev)[ll_block->bar]; + if (!ll_region->vaddr) + return -ENOMEM; + ll_region->vaddr += ll_block->off; ll_region->paddr = pdev->resource[ll_block->bar].start; ll_region->paddr += ll_block->off; ll_region->sz = ll_block->sz; dt_region->vaddr = pcim_iomap_table(pdev)[dt_block->bar]; + if (!dt_region->vaddr) + return -ENOMEM; + dt_region->vaddr += dt_block->off; dt_region->paddr = pdev->resource[dt_block->bar].start; dt_region->paddr += dt_block->off; @@ -269,12 +278,18 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, struct dw_edma_block *dt_block = &vsec_data.dt_rd[i]; ll_region->vaddr = pcim_iomap_table(pdev)[ll_block->bar]; + if (!ll_region->vaddr) + return -ENOMEM; + ll_region->vaddr += ll_block->off; ll_region->paddr = pdev->resource[ll_block->bar].start; ll_region->paddr += ll_block->off; ll_region->sz = ll_block->sz; dt_region->vaddr = pcim_iomap_table(pdev)[dt_block->bar]; + if (!dt_region->vaddr) + return -ENOMEM; + dt_region->vaddr += dt_block->off; dt_region->paddr = pdev->resource[dt_block->bar].start; dt_region->paddr += dt_block->off; -- 2.7.4