Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp489899pxb; Wed, 3 Feb 2021 10:04:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJw6T5AUOIH0jh66DoRnXYO3SXY4AC/E62BScOrv9TDsGz7bYvPWtetovd07N5UxVTUkia3a X-Received: by 2002:a5d:5902:: with SMTP id v2mr4839803wrd.426.1612375496726; Wed, 03 Feb 2021 10:04:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612375496; cv=none; d=google.com; s=arc-20160816; b=aIi2cA2zEieDRi1DDC3QIbWqP8dWoTZ3YiGEWRfExkVZyP4LcEyz5UB83OadgXnZG7 diRlkZmdfY7/wVBXl4L32C8XKIPrZjl1cGpsj00YjNl9zqikYrIuVqe77mgnCk4zS1yJ +j3xiaEkYHrqIaQxuOwTmmNpAUXY67cFc+JhWiqvkCVUR4vvvyqXFKUijniNEt1zDEkw 2g9uXjXjUF+oSE5l4QU2Lnu88smWcrIRXwI9Bgvd5qpXS8Qjd4qcZUfcOizEDfZRNplr CXSXX/fzsWVIrT/ZrbwlW69dRzJ+1rnbxkM2zOx6xJsZLvkMmiSI0TWAiVpokFe1g6Lf poLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:references:in-reply-to :message-id:date:subject:to:from:dkim-signature; bh=LeJkYXCorWtiaP+yCGj+HszRDmiDY/6LzTvN7R0PDJU=; b=TrvfPcGoXJpu954dvGclTcXFivUyDZVIR62sm3wJp9VGXz81z9bny1vgdxHW2dITgI o131az2E9mrmKff4bIh3ghbhCP/P84nj4HP8MFoJxD+tmkYleABwWNv3aNWQJfaGgA+M aMXeGg/XWltZHKbKyr3Xifck+7GmiHnJh7UgEItSqYvOWdoKMgSbZuoACmMyUPB3YD8v hnOIgt7UIaPhNLI5y40Awz0GBtmp/JkjHDQeKvJdRuiun8ATLrrs15dzYuOfwQYH2QS4 QP+Qt+TxtZj12RSh7w0uqDOPqXWpuaeiCZeNBOJPGAYZb5a2WmRbXW052gFYfxg8Quju IXNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=dPM96uZ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m10si1753113edi.26.2021.02.03.10.04.14; Wed, 03 Feb 2021 10:04:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=dPM96uZ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232263AbhBCSCz (ORCPT + 99 others); Wed, 3 Feb 2021 13:02:55 -0500 Received: from smtprelay-out1.synopsys.com ([149.117.73.133]:49790 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232452AbhBCR6a (ORCPT ); Wed, 3 Feb 2021 12:58:30 -0500 Received: from mailhost.synopsys.com (mdc-mailhost2.synopsys.com [10.225.0.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id A1EF4402D8; Wed, 3 Feb 2021 17:57:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1612375047; bh=71t8kLn/h4uRT+rZrsVOIM9WjcoyjC97XsyNd4xo0/8=; h=From:To:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=dPM96uZ5221t+dWJ1R5u00mL/Nd5prdLl66I/vTH90d/uz8h5Ca6VeNDQyar6/nCp d5mLcBN2b9SRZdnvb4cjxW4SBcY9pyEjifuG67VwSq3kc2COCb6CrWa/r4jx55spov V+eUNAFVw4k29YaBdPVfGlUopxcyQvsTF3LcmziGHlCVNQTSqCDPjIJhOKlFIPFNAa xYJhtW2sUgcoc30B5rPwgGxWAS9LB0aJkuyaXyWg70ud6k4v+QbHJHznllYDtPT9nL nUGGhpzi9f21s57VXvklSL7s/WhyiLiRIpdzzwNKd/3EZQWY4ORa8uS0ZlbP6VxoWD b+8kqHYjg0xXA== Received: from de02dwia024.internal.synopsys.com (de02dwia024.internal.synopsys.com [10.225.19.81]) by mailhost.synopsys.com (Postfix) with ESMTP id 7DBADA0062; Wed, 3 Feb 2021 17:57:26 +0000 (UTC) X-SNPS-Relay: synopsys.com From: Gustavo Pimentel To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Vinod Koul , Dan Williams , Bjorn Helgaas , Gustavo Pimentel Subject: [PATCH v3 12/15] dmaengine: dw-edma: Fix crash on loading/unloading driver Date: Wed, 3 Feb 2021 18:57:04 +0100 Message-Id: <9a54d5c18d4e26e7c5a2d33e278e31cbb8f6c1af.1612374941.git.gustavo.pimentel@synopsys.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the driver is compiled as a module and loaded if we try to unload it, the Kernel shows a crash log. This Kernel crash is due to the dma_async_device_unregister() call done after deleting the channels, this patch fixes this issue. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c index 8d8292e..f7a1930 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -986,22 +986,21 @@ int dw_edma_remove(struct dw_edma_chip *chip) /* Power management */ pm_runtime_disable(dev); + /* Deregister eDMA device */ + dma_async_device_unregister(&dw->wr_edma); list_for_each_entry_safe(chan, _chan, &dw->wr_edma.channels, vc.chan.device_node) { - list_del(&chan->vc.chan.device_node); tasklet_kill(&chan->vc.task); + list_del(&chan->vc.chan.device_node); } + dma_async_device_unregister(&dw->rd_edma); list_for_each_entry_safe(chan, _chan, &dw->rd_edma.channels, vc.chan.device_node) { - list_del(&chan->vc.chan.device_node); tasklet_kill(&chan->vc.task); + list_del(&chan->vc.chan.device_node); } - /* Deregister eDMA device */ - dma_async_device_unregister(&dw->wr_edma); - dma_async_device_unregister(&dw->rd_edma); - /* Turn debugfs off */ dw_edma_v0_core_debugfs_off(chip); -- 2.7.4