Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: /W9l062rcCZ9z29mYqOUwV4+VpY4L42/UYs0LK79IfZbfIl3G2M5oSubHi4FYeP83RoE5P0B1E
 SIZlqort0w3A==
IronPort-SDR: rk+x0kdRJQ2cymIKplWCGUcSjS3JrXe3MwBpXeb8yoLu7a7kPaAwIFvRxBkTgfW8d4dCqcFn6k
 bIbIw7/7T1ZA==
Date:   Wed, 3 Feb 2021 21:30:24 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Timur Tabi <timur@kernel.org>
Cc:     Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        linux-kernel@vger.kernel.org, vbabka@suse.cz, linux-mm@kvack.org,
        willy@infradead.org, akpm@linux-foundation.org,
        torvalds@linux-foundation.org, roman.fietze@magna.com,
        keescook@chromium.org, john.ogness@linutronix.de,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        akinobu.mita@gmail.com
Subject: Re: [PATCH][RESEND] lib/vsprintf: make-printk-non-secret printks all
 addresses as unhashed
Message-ID: <YBr50OxRnoZJ4jTw@smile.fi.intel.com>
References: <20210202213633.755469-1-timur@kernel.org>
 <YBpyzxBYIYapHaDT@alley>
 <YBqlooegQgEfPG4T@alley>
 <19c1c17e-d0b3-326e-97ec-a4ec1ebee749@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <19c1c17e-d0b3-326e-97ec-a4ec1ebee749@kernel.org>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Feb 03, 2021 at 12:58:41PM -0600, Timur Tabi wrote:
> On 2/3/21 7:31 AM, Petr Mladek wrote:
> > Also please make sure that lib/test_printf.c will work with
> > the new option.
> 
> As you suspected, it doesn't work:
> 
> [  206.966478] test_printf: loaded.
> [  206.966528] test_printf: plain 'p' does not appear to be hashed
> [  206.966740] test_printf: failed 1 out of 388 tests
> 
> What should I do about this?
> 
> On one hand, it is working as expected: %p is not hashed, and that should be
> a warning.
> 
> On the other hand, maybe test_printf should be aware of the command line
> parameter and test to make sure that %p is NOT hashed?

test_printf.c should be altered accordingly to avoid any failed test cases.
I.o.w. you need to have some kind of conditional there:

 if (kernel_cmdline_parameter_foo)
	expect bar
 else
	expect baz

-- 
With Best Regards,
Andy Shevchenko