Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: EjwDIsVy3c6WF00rPkdDgid8M99z0Vzt4GJwwIG4JJeYb/54V2BfjiATgnWxOG/aVFwHmMBl+L
 bqFx2YPcPDYw==
IronPort-SDR: wvqFBOGBv6TkhLjc0tjMG0iEkYLihlCupR907htdu1Pcsy0EU9gMdQL423diT2xYCi2JPIc9N0
 0fN5E8iG8pTw==
Date:   Wed, 3 Feb 2021 21:35:24 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Mario Limonciello <mario.limonciello@dell.com>
Cc:     Hans De Goede <hdegoede@redhat.com>,
        Mark Gross <mgross@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86: Move all dell drivers to their own
 subdirectory
Message-ID: <YBr6/ClMRV4Sw/kN@smile.fi.intel.com>
References: <20210203192637.2947540-1-mario.limonciello@dell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210203192637.2947540-1-mario.limonciello@dell.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Feb 03, 2021 at 01:26:37PM -0600, Mario Limonciello wrote:
> A user without a Dell system doesn't need to pick any of these
> drivers.
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>

You are fast, thanks!

...

> +menuconfig DELL_X86_PLATFORM_DRIVERS

I'm not sure this is a good order, rather X86_PLATFORM_DRIVERS_DELL?

...

> +if DELL_X86_PLATFORM_DRIVERS
> +source "drivers/platform/x86/dell/Kconfig"
> +endif # DELL_X86_PLATFORM_DRIVERS

Would you expect something else here?

I would rather unconditionally source this and inside it do that menuconfig
with ifdeffery.

-- 
With Best Regards,
Andy Shevchenko