Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   Andy Lutomirski <luto@amacapital.net>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH 09/11] x86/fault: Rename no_context() to kernelmode_fixup_or_oops()
Date:   Wed, 3 Feb 2021 11:53:03 -0800
Message-Id: <88AA1DD6-615B-4049-B335-F2F40F85EF08@amacapital.net>
References: <20210203193949.GI13819@zn.tnic>
Cc:     Andy Lutomirski <luto@kernel.org>, x86@kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Yonghong Song <yhs@fb.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
In-Reply-To: <20210203193949.GI13819@zn.tnic>
To:     Borislav Petkov <bp@alien8.de>
Precedence: bulk


> On Feb 3, 2021, at 11:39 AM, Borislav Petkov <bp@alien8.de> wrote:
>=20
> =EF=BB=BFOn Sun, Jan 31, 2021 at 09:24:40AM -0800, Andy Lutomirski wrote:
>> The name no_context() has never been very clear.  It's only called for
>> faults from kernel mode, so rename it and change the no-longer-useful
>> user_mode(regs) check to a WARN_ON_ONCE.
>>=20
>> Cc: Dave Hansen <dave.hansen@linux.intel.com>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Signed-off-by: Andy Lutomirski <luto@kernel.org>
>> ---
>> arch/x86/mm/fault.c | 28 ++++++++++------------------
>> 1 file changed, 10 insertions(+), 18 deletions(-)
>>=20
>> diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
>> index 177b612c7f33..04cc98ec2423 100644
>> --- a/arch/x86/mm/fault.c
>> +++ b/arch/x86/mm/fault.c
>> @@ -693,17 +693,10 @@ page_fault_oops(struct pt_regs *regs, unsigned long=
 error_code,
>> }
>>=20
>> static noinline void
>> -no_context(struct pt_regs *regs, unsigned long error_code,
>> -       unsigned long address, int signal, int si_code)
>> +kernelmode_fixup_or_oops(struct pt_regs *regs, unsigned long error_code,=

>> +             unsigned long address, int signal, int si_code)
>=20
> Ew, I don't like functions with "or" in the name - they're probably not
> doing one thing only as they should.
>=20
> Why not simply "handle_kernel_fault" ?

Hmm, I could maybe get behind handle_kernelmode_fault.  I=E2=80=99ll contemp=
late it.  I like the name of the function indicating that either it returns a=
fter fixing it or it doesn=E2=80=99t return.

I refuse to say =E2=80=9Ckernel=E2=80=9D without qualification. In this $@!$=
 file, we have kernel _mode_, kernel _address_, and kernel _privilege_, and t=
hey are all different.

>=20
> Also, all the callsites now do:
>=20
>    if (!user_mode(regs)) {
>        kernelmode_fixup_or_oops
>        ...
>=20
> I guess you can push the "user_mode" check inside that function for less
> hairy code at the callsites.

I feel like that would be more obfuscated =E2=80=94 then the function would r=
eturn without fixing anything for usermode faults, return after fixing it fo=
r kernel mode faults, or oops.

>=20
>> {
>> -    if (user_mode(regs)) {
>> -        /*
>> -         * This is an implicit supervisor-mode access from user
>> -         * mode.  Bypass all the kernel-mode recovery code and just
>> -         * OOPS.
>> -         */
>> -        goto oops;
>> -    }
>> +    WARN_ON_ONCE(user_mode(regs));
>=20
> I guess...
>=20
> --=20
> Regards/Gruss,
>    Boris.
>=20
> https://people.kernel.org/tglx/notes-about-netiquette