Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   04 Feb 2021 07:33:37 +0900
Message-ID: <87y2g494b0.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Mark Brown <broonie@kernel.org>
Cc:     Sameer Pujar <spujar@nvidia.com>, thierry.reding@gmail.com,
        jonathanh@nvidia.com, alsa-devel@alsa-project.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        sharadg@nvidia.com
Subject: Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function
In-Reply-To: <20210203172415.GH4880@sirena.org.uk>
References: <1612368575-25991-1-git-send-email-spujar@nvidia.com>
        <1612368575-25991-2-git-send-email-spujar@nvidia.com>
        <20210203161951.GG4880@sirena.org.uk>
        <64b65aaf-9971-e071-5d52-02286fe0cacc@nvidia.com>
        <20210203172415.GH4880@sirena.org.uk>
User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk


Hi

> > > > +int graph_remove(struct platform_device *pdev);
> 
> > > I think this needs better namespacing if it's going to be exported.
> 
> > audio_graph_remove() can be a better choice?
> 
> Yeah, that looks reasonable.

Nice naming I think.
In such case,  update also graph_parse_of() is nice idea for me.

	- int graph_parse_of(...)
	+ int audio_graph_parse_of()

Thank you for your help !!

Best regards
---
Kuninori Morimoto