Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp690298pxb; Wed, 3 Feb 2021 15:30:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJzaFiTzuS9q0GnUqnQiCfkjHc5OMtD8WLWHnxDTFDZFB6tU191DZ+ekUDaAuqgVeLpE+X73 X-Received: by 2002:a17:906:19c3:: with SMTP id h3mr5431887ejd.429.1612395043965; Wed, 03 Feb 2021 15:30:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612395043; cv=none; d=google.com; s=arc-20160816; b=gagLq5uL8MYLrcdFWnSIAoLOdoukk+3Asr8Qv5g3ZCDRToFILo8eylfMXRzdgkyld4 nOp/TI8k47723/fHG37p70uL0bbxUyd5ThIravH1lT/sJ3Pa7VAwq9M2CtQ6/FvJJ4sV W+vWcMW3zYR3BWlNCUYU1R7ddhougTzGQUIgxpq3n6qvfONgues04zbyT1eKW9kXtcoF JIjdOk3MmV8mtB5js66Ek17CtHfQY084PMMoHV3QS6C5vkOMhWymffCyXialH8ma4Tx5 h6sNKbX1xT+yqNQoh7KtCK5T4GnzLCuYzqt6vV0WviWl87iyu9GfqBUb9VzSmXWi1HrW aJ8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=tdf+flEC8Hvd/fcRhVdHoDNaYv5b/qLbWIiaAMub1ho=; b=KXfrjB2Rem7BlZYBrc/GPodC4Tg+rIUiaSv8DYwGGORyw+FqT20DIuZaYxWYqofb3i hFgtXhXL36KgkA5pSUh8ao4i3UnDNooMqvjQHgyQyUHIp9o35LDth9xbYzEeF3/tvdn4 LvVvOca/8KdpdgI5iR5ec2JyK5/w/SKlSBfqQje5vH1oYPcomQxRTz4Sq1RJp8wdb7zC BNmH7wWvDkd45omeJ06fZQN7G8+pMBqeMFSxC4vbHYzJM5kKlMNiNK1dZXNZolgCMfko uG6OxI0ayJ0EO0I8LGA43oAu2hg9viEsvkhm0encGutKbz2F499L0lWKx47TJvbcVw8J oiXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r26si2345599edx.381.2021.02.03.15.30.18; Wed, 03 Feb 2021 15:30:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233562AbhBCX0e (ORCPT + 99 others); Wed, 3 Feb 2021 18:26:34 -0500 Received: from mga06.intel.com ([134.134.136.31]:32276 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233089AbhBCX0d (ORCPT ); Wed, 3 Feb 2021 18:26:33 -0500 IronPort-SDR: txRAmVsnowjXhLgU8qwO7RBoEXxrh8ceeQ+TAvA9E5vb+BECWkzk4imf5jfSTtMClA4asI/fit 0MNkeVsGwXlA== X-IronPort-AV: E=McAfee;i="6000,8403,9884"; a="242645457" X-IronPort-AV: E=Sophos;i="5.79,399,1602572400"; d="scan'208";a="242645457" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2021 15:25:41 -0800 IronPort-SDR: fW7mgwdfpsdFzDrqk5qrVmoOWeS/KcOuXz00CTZ1ABq3ZKKAW2TAg0BuHC5AXrTRwJQEolUKwU +K/djcrZvXiQ== X-IronPort-AV: E=Sophos;i="5.79,399,1602572400"; d="scan'208";a="356185661" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.209.23.15]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2021 15:25:40 -0800 Date: Wed, 3 Feb 2021 15:25:40 -0800 From: Jesse Brandeburg To: "Andrea Parri (Microsoft)" Cc: linux-kernel@vger.kernel.org, "K . Y . Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Michael Kelley , linux-hyperv@vger.kernel.org, Saruhan Karademir , Juan Vazquez , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org Subject: Re: [PATCH net] hv_netvsc: Reset the RSC count if NVSP_STAT_FAIL in netvsc_receive() Message-ID: <20210203152540.00006fe8@intel.com> In-Reply-To: <20210203113602.558916-1-parri.andrea@gmail.com> References: <20210203113602.558916-1-parri.andrea@gmail.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrea Parri (Microsoft) wrote: > Commit 44144185951a0f ("hv_netvsc: Add validation for untrusted Hyper-V > values") added validation to rndis_filter_receive_data() (and > rndis_filter_receive()) which introduced NVSP_STAT_FAIL-scenarios where > the count is not updated/reset. Fix this omission, and prevent similar > scenarios from occurring in the future. > > Reported-by: Juan Vazquez > Signed-off-by: Andrea Parri (Microsoft) > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: netdev@vger.kernel.org > Fixes: 44144185951a0f ("hv_netvsc: Add validation for untrusted Hyper-V values") Reviewed-by: Jesse Brandeburg