Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp705041pxb; Wed, 3 Feb 2021 16:02:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJznTBUHLf4IrDCzc5KgUrS6Z71DWYtc8FD7Bd2t4rx8vscKvPb1n3aiMXeluz+1t3pwFNOE X-Received: by 2002:aa7:c813:: with SMTP id a19mr5778248edt.136.1612396967846; Wed, 03 Feb 2021 16:02:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612396967; cv=none; d=google.com; s=arc-20160816; b=f9HJcymSUsIh2i5V23ab/gBY+93xZTpdwLU57fiL92qXFRsCWl1Kiy7FO7ijXbbGd8 rekDF+y/ZeD5Iv7GV9E/BnRiQARGpcDErrbNB551yi50eTdEl2YExpXm2DNebEMo5sw2 2XE28Mdre/YmiSVEuBUWi1qqaa8L7lnC8yYGwnmI2fz4ZXNW8vULrHx8HMoUCIIFULKn Q2tpN+AM35ODgwaBJkwQnZsiSCvBPqVmIJXGF9azNlYuQVezdf5yK3iTd5QZexdrcQKR LhCzx24ZKaNyq1zdZpipREUZyCZq4Xi7p63OekHAFNLe0yDLVQVVQb3s6o/tgrhVl/GF KAaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=26fZ9RQPj3ZGtvSejTqjoITM0JSJsQD8uUBS66SB+rE=; b=kFnJQbdt5AzCyZOqBUcDGB4KC9gf/8CXu1igoRqazXvIzQ72sqGf5z1mteP5wrtylK mobf9Z2RZdCpv+PkdwjG5Ro9B/Zcn68orAArfXQB5TJaF8n7qAtiqMKCm2ZetVEv4+js p3YaSoJIFFUrOxtcVOfn1K1RBJEvmdX1qAVM2K/nl5ppMypNLw1TliPJXzBZguutqdRf SpXYTXVnmVXlLXX9anqG8f/kundw75PE90D6g517kofFKRo5ZGE/cyLVuvJ/GVHepmra PqFhbWsirWbIRzdY3cKwIpuh2T17Ykw96PI5GuEQUcW2ayN41hqgA5XhAgMSNsDayLH1 4qFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p5si2520705edq.409.2021.02.03.16.02.23; Wed, 03 Feb 2021 16:02:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233871AbhBCX7Q (ORCPT + 99 others); Wed, 3 Feb 2021 18:59:16 -0500 Received: from correo.us.es ([193.147.175.20]:58782 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233517AbhBCX7O (ORCPT ); Wed, 3 Feb 2021 18:59:14 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id D76EBDED3A for ; Thu, 4 Feb 2021 00:58:29 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id C8CB3DA792 for ; Thu, 4 Feb 2021 00:58:29 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id BE070DA73F; Thu, 4 Feb 2021 00:58:29 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-106.1 required=7.5 tests=ALL_TRUSTED,BAYES_50, FORGED_MUA_MOZILLA,NICE_REPLY_A,SMTPAUTH_US2,URIBL_BLOCKED, USER_IN_WELCOMELIST,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id A7B45DA704; Thu, 4 Feb 2021 00:58:27 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 04 Feb 2021 00:58:27 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 78B38426CC84; Thu, 4 Feb 2021 00:58:27 +0100 (CET) Date: Thu, 4 Feb 2021 00:58:27 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Colin King Cc: Jozsef Kadlecsik , Florian Westphal , "David S . Miller" , Jakub Kicinski , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: nf_tables: remove redundant assignment of variable err Message-ID: <20210203235827.GA21793@salvia> References: <20210128175923.645865-1-colin.king@canonical.com> <20210203230421.GA18404@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210203230421.GA18404@salvia> User-Agent: Mozilla/5.0 X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 04, 2021 at 12:04:21AM +0100, Pablo Neira Ayuso wrote: > On Thu, Jan 28, 2021 at 05:59:23PM +0000, Colin King wrote: > > From: Colin Ian King > > > > The variable err is being assigned a value that is never read, > > the same error number is being returned at the error return > > path via label err1. Clean up the code by removing the assignment. > > Applied to nf, thanks. Sorry, I meant, nf-next