Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp770762pxb; Wed, 3 Feb 2021 18:11:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJwBv2j1Q4UpIdO6E2W1cYpvDh20bn/5bv9t2Lxgz5yW1sB2G+3doWZeWSTsaziKPpxZwYjr X-Received: by 2002:a17:906:3f97:: with SMTP id b23mr5797217ejj.306.1612404673171; Wed, 03 Feb 2021 18:11:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612404673; cv=none; d=google.com; s=arc-20160816; b=aGBpgK2JLIOlMtlISq4PpMrnmIVeD5eKksKLqYuE1IScsYi5fUpmCzVU0V1bzStNkq VB8hPUuy+BKIsKbaH6+jlOlH6Fqru/G8k0iNxUl5gNZuK3c0veZDrdB4LwGGihfjxcKB lhQhDvwTstIItWwoPKebL27MqxXOw7HyojWV2iIDBMy5UoJLprAnmjX8Aj137+sZ1lX2 nea2VMOShQn/6o3RGECKvKDha3CZuYSOTKsU08NKGeOH+O1R7lmbDZt41Cmsso//sKig hFmRNCFtpvT3Md+mQLdndANolbAS0QomNYn2WwEF7hGt20qjDAxmLa7XJ24gOtzevhWY 7oVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=KLJyaQc0oVoHoxB+uqWEvdlortXd+vxXfOpecJYXj7Q=; b=kYLUHnSrN/xrjoBjgHkNoydk+/7x4F/MdEsk4eVWlEFgqZqbbSIPpRlx9xu8ysZGZC LJ3sEDk3RR4zRG6xfDXfRWeCzsbTmQ91aw4joQviqQst4kzykECvOpprHAtymynSKfJl /DBqi/Wp7mJfGZ8N9AYmg8B3+xOAIsE8lqJBpIJkeOpPLRwM6kQNka2VJiSXx8jtkdW0 PbalQ1uSR1+j850NeyY+sm3lnsNXgRbFpwjVdJ/I/+R5YP/2rBMUhseLBgJvqkhXMVQj hBvgjA4T3xMCrO4+JqWxbu3+Obi89ZeCZX8TJIvf6wtbNZjiIxYPBSryD4ZzDird5V2A SLZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m19si3004367edd.509.2021.02.03.18.10.47; Wed, 03 Feb 2021 18:11:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233622AbhBCXJs (ORCPT + 99 others); Wed, 3 Feb 2021 18:09:48 -0500 Received: from correo.us.es ([193.147.175.20]:45100 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233601AbhBCXFF (ORCPT ); Wed, 3 Feb 2021 18:05:05 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 4E7E7DA88C for ; Thu, 4 Feb 2021 00:04:24 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 3FEBDDA797 for ; Thu, 4 Feb 2021 00:04:24 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 29F12DA78D; Thu, 4 Feb 2021 00:04:24 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-106.1 required=7.5 tests=ALL_TRUSTED,BAYES_50, FORGED_MUA_MOZILLA,NICE_REPLY_A,SMTPAUTH_US2,URIBL_BLOCKED, USER_IN_WELCOMELIST,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 28EE1DA73D; Thu, 4 Feb 2021 00:04:22 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 04 Feb 2021 00:04:22 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id F12B6426CC85; Thu, 4 Feb 2021 00:04:21 +0100 (CET) Date: Thu, 4 Feb 2021 00:04:21 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Colin King Cc: Jozsef Kadlecsik , Florian Westphal , "David S . Miller" , Jakub Kicinski , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: nf_tables: remove redundant assignment of variable err Message-ID: <20210203230421.GA18404@salvia> References: <20210128175923.645865-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210128175923.645865-1-colin.king@canonical.com> User-Agent: Mozilla/5.0 X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2021 at 05:59:23PM +0000, Colin King wrote: > From: Colin Ian King > > The variable err is being assigned a value that is never read, > the same error number is being returned at the error return > path via label err1. Clean up the code by removing the assignment. Applied to nf, thanks.