Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp798600pxb; Wed, 3 Feb 2021 19:15:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJz3GR1rhrErK9NMOm6HCXwbIvqCYuCtGPaa1qe6VVPMk7soCJ8DxbUvkGAuAcrIIu+ZO8b9 X-Received: by 2002:a05:6402:26d5:: with SMTP id x21mr4769422edd.50.1612408548929; Wed, 03 Feb 2021 19:15:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612408548; cv=none; d=google.com; s=arc-20160816; b=0iwKrXBMFSozqzQzuzZIBkAnMAX3TWTOCQTCeIzOMT6U+5kr4mH8HcvUGKTTG2/LyB sT35T7UWE4bhqjTUOfJ+jIGAhnoxG8mAky7EYouZU9wQdA8+kMRaJrqUy+rV7cC7z1B4 y/iV0yQsXkYNOOTg6WiAPkSWuA20gDJJwZaKTa91qX8y5y2DE+fI3RqQKDtagp8/em1K 2vqrTjDVTFFuQ3piNUkW6bNyPYfmvrY2tFlEwgpqgh2bY3WpJpnpjbRVqdj2uvn1qKx6 qlNuIwu3Pgy1cy8ZvPi0nMiVToRkCt6j+ajRlaSbDwvRTZTzcNLxMsWXXvF+dPHofsOU 1OLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=5XAa69mAO/7c+Pwl/wPj2bJIV2rI+2yCCaq7t8YFjQs=; b=VBHgst2Gp2GCvDBdJC2NJkM3YAsS+D2HFVii/vc/H5HN8NMJfBWd0opYp+aSFOBpjS UdwspOsxxIwurqtd+tGu1ljLiiY3iz2Mz395khAb54+ymVjkzmIrrYE5HU6OniylKLO4 +5enPsL4T06JINwVI0YTyz0v/uZGpd3WeAMX7ixXx2uPA1IEOZAy3sD184GrHc7rH8OQ ih6dMiLJv8SuBSwrQLO+UhQAcPtIVKDzqjD5DOLDIhkDA2WNwEi4++lMQyqLtJHAmMYI GQnAQm2foNZdPrvjr8YdxFJ92v54vLJ7gzPaZP2X3uv/KJIUgMRkRwZoe6wLMkWXkKwA 7wzg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qc17si2441330ejb.265.2021.02.03.19.15.24; Wed, 03 Feb 2021 19:15:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231553AbhBDDMt (ORCPT + 99 others); Wed, 3 Feb 2021 22:12:49 -0500 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:49013 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229601AbhBDDMt (ORCPT ); Wed, 3 Feb 2021 22:12:49 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R391e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UNolUB6_1612408324; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UNolUB6_1612408324) by smtp.aliyun-inc.com(127.0.0.1); Thu, 04 Feb 2021 11:12:04 +0800 From: Yang Li To: mark@fasheh.com Cc: jlbec@evilplan.org, joseph.qi@linux.alibaba.com, ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] ocfs2: Remove unneeded return variable Date: Thu, 4 Feb 2021 11:12:03 +0800 Message-Id: <1612408323-23579-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch removes unneeded return variables, using only '0' instead. It fixes the following warning detected by coccinelle: ./fs/ocfs2/stack_o2cb.c:69:5-16: Unneeded variable: "o2dlm_flags". Return "0" on line 84 Reported-by: Abaci Robot Signed-off-by: Yang Li --- fs/ocfs2/stack_o2cb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c index dbf8b57..2da9633 100644 --- a/fs/ocfs2/stack_o2cb.c +++ b/fs/ocfs2/stack_o2cb.c @@ -66,8 +66,6 @@ static inline int mode_to_o2dlm(int mode) } static int flags_to_o2dlm(u32 flags) { - int o2dlm_flags = 0; - map_flag(DLM_LKF_NOQUEUE, LKM_NOQUEUE); map_flag(DLM_LKF_CANCEL, LKM_CANCEL); map_flag(DLM_LKF_CONVERT, LKM_CONVERT); @@ -81,7 +79,7 @@ static int flags_to_o2dlm(u32 flags) /* map_flag() should have cleared every flag passed in */ BUG_ON(flags != 0); - return o2dlm_flags; + return 0; } #undef map_flag -- 1.8.3.1