Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp816581pxb;
        Wed, 3 Feb 2021 20:00:13 -0800 (PST)
X-Google-Smtp-Source: ABdhPJw4xDjWYCZ37zEHsXebHaeuGmPDEB6UMPjjsTF0napBvPss9xAG3Qc7vLoQ35M38ey4Fx7O
X-Received: by 2002:a05:6402:104e:: with SMTP id e14mr6318438edu.316.1612411212897;
        Wed, 03 Feb 2021 20:00:12 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1612411212; cv=none;
        d=google.com; s=arc-20160816;
        b=oAhnNUYdbw1UnEqbA0j4IMU3h/689HrTUoXVw7ZAxVqs7D3vocs/623sciaEDko/+i
         be5/kzaTsuq9hkzvLg+z06sZ6e64xIhothLgyqqRZPWqObKJVlVy1ctZHoOzXnuzanCJ
         yPqRG481yzxWMDWWH+o49xsjollFB/6hPc6bElgGMeIMOB6Le9Tpa0CzhPRqLrbcJcVJ
         Xle+8Aaiped7nJwFMfdYEfYy/MFkG54dSEsYPw9oLmsuamKIAedsGynvlhkFj5bBmbQh
         At7rH2utPhdl88sdK1HB4xaHZWwBXsAhTQjsoNNts+CO0g+nvXZmin8v+CTqh4FlTsY5
         P/bg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=DwIn2j1vQcvA9mQebkfkn8fWS9nwtb6i848UUWLIsQc=;
        b=EKyPIvLvWe/HjxF7rml+GLjHHJEOYE692+ngl6TIlETco/f9vgvwwG5o3pIu8o4O4I
         E0SCvsnf2Q0S/Y7PHJZJjIAfsXNOPb8MsO7oHNgNMcz6xnhNt4M6S78qP1kgKFBOGnJ5
         CuE9JO9nbzFZSeEs6GtuBxkoBA+fWc56LoH0cT2kpXaDSd9oLmV+KCGsZAQWzXtk+X4b
         d3dAlIgNMkxey530ziGn2ZVs+ybFfK+VwnwKO1AuOeWRxT2Xzv8VQ1H9SSqpNSfaFa67
         xFz/o2hn1TOL+MWI/877mIvrAjb0u27n/XPQTaaZ6UxeIn+XGhugXLpZ6erTGAW5PkpO
         RXdg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=IAQYv23Z;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id hr22si2646702ejc.388.2021.02.03.19.59.48;
        Wed, 03 Feb 2021 20:00:12 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=IAQYv23Z;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233516AbhBDDqr (ORCPT <rfc822;lkml.araj@gmail.com> + 99 others);
        Wed, 3 Feb 2021 22:46:47 -0500
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:12454 "EHLO
        hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229601AbhBDDqq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 3 Feb 2021 22:46:46 -0500
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B601b6dfe0000>; Wed, 03 Feb 2021 19:46:06 -0800
Received: from [10.25.102.154] (172.20.145.6) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 4 Feb
 2021 03:46:01 +0000
Subject: Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function
To:     Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        Mark Brown <broonie@kernel.org>
CC:     <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
        <alsa-devel@alsa-project.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <sharadg@nvidia.com>
References: <1612368575-25991-1-git-send-email-spujar@nvidia.com>
 <1612368575-25991-2-git-send-email-spujar@nvidia.com>
 <20210203161951.GG4880@sirena.org.uk>
 <64b65aaf-9971-e071-5d52-02286fe0cacc@nvidia.com>
 <20210203172415.GH4880@sirena.org.uk>
 <87y2g494b0.wl-kuninori.morimoto.gx@renesas.com>
From:   Sameer Pujar <spujar@nvidia.com>
Message-ID: <c090ef0b-3af8-4ff3-027d-d8c84019eca4@nvidia.com>
Date:   Thu, 4 Feb 2021 09:15:54 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <87y2g494b0.wl-kuninori.morimoto.gx@renesas.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-Originating-IP: [172.20.145.6]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1612410366; bh=DwIn2j1vQcvA9mQebkfkn8fWS9nwtb6i848UUWLIsQc=;
        h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
         MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:
         Content-Language:X-Originating-IP:X-ClientProxiedBy;
        b=IAQYv23ZZbiCxLRGuJWC1dUROtZHT2sm1b/i6fGFUEPvJSl1wQkgc5mWy6rx7GHDv
         xsBB2g5ZtEvYaQub+VCtXdIkm6hqsOymcBeHZnY8HVAkTqqfotN8VIoRkDAeN7awPT
         ENmWJ8Q1qqW5eIjQTXe8P67Ncf/xR6WqgcYhwUrqghlyGONc/qrClXxwCTtalc9XMs
         F/0LsnBF0OwwK9ZdvVj7Y1msr5U1M8qzcLloJkRtDbo2NBFQwF/4VKVxPQJKlAIsFa
         4knX5TfEU1Lj2Wa8j4s9I8o6AJo7w7x45orTAaUpOTe8C8XY+lSLTVVIjBOa/eihQw
         qY5vE2oI20Dbg==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2/4/2021 4:03 AM, Kuninori Morimoto wrote:
> External email: Use caution opening links or attachments
>
>
> Hi
>
>>>>> +int graph_remove(struct platform_device *pdev);
>>>> I think this needs better namespacing if it's going to be exported.
>>> audio_graph_remove() can be a better choice?
>> Yeah, that looks reasonable.
> Nice naming I think.
> In such case,  update also graph_parse_of() is nice idea for me.
>
>          - int graph_parse_of(...)
>          + int audio_graph_parse_of()

OK, Will update following.

graph_remove()=C2=A0=C2=A0=C2=A0=C2=A0 --> audio_graph_remove()
graph_parse_of()=C2=A0=C2=A0 --> audio_graph_parse_of()
graph_card_probe() --> audio_graph_card_probe()