Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] x86: Add a prompt for HPET_EMULATE_RTC
To:     Anand K Mistry <amistry@google.com>, x86@kernel.org
Cc:     Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org
References: <20210204132043.1.I2392cf11fb353d10459958100b69d93346fa167c@changeid>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <ec6caa23-28d6-9695-2b0f-b3ba9ef28b60@infradead.org>
Date:   Wed, 3 Feb 2021 19:47:30 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <20210204132043.1.I2392cf11fb353d10459958100b69d93346fa167c@changeid>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/3/21 6:21 PM, Anand K Mistry wrote:
> This does two things:
> 1. Makes the option visible in menuconfig, allowing the user to easily
>    disable this option
> 2. Allows olddefconfig to respoct the option if it is set in the old
>    .config file
> 
> It's not clear exactly why the second consequence is true, but it
> appears to be because when the conf tool reads the config file, it only
> respects the existing setting if the option is "visible" (see
> scripts/kconfig/symbol.c:381).
> 
> Signed-off-by: Anand K Mistry <amistry@google.com>
> ---

Hi,

When you run "make olddefconfig", should this "depends on"
line evaluate to true or false?
I.e., what are the settings of these symbols in the old .config file?


  	depends on HPET_TIMER && (RTC=y || RTC=m || RTC_DRV_CMOS=m || RTC_DRV_CMOS=y)

If not, is there some out-of-tree driver involved?
I'm having a little trouble seeing why this is needed.


>  arch/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 21f851179ff0..28f814493c7b 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -890,6 +890,7 @@ config HPET_TIMER
>  
>  config HPET_EMULATE_RTC
>  	def_bool y
> +	prompt "HPET RTC emulation"
>  	depends on HPET_TIMER && (RTC=y || RTC=m || RTC_DRV_CMOS=m || RTC_DRV_CMOS=y)
>  
>  config APB_TIMER
> 


thanks.
-- 
~Randy