Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp876007pxb; Wed, 3 Feb 2021 22:20:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJwqiq8p8hAn2AlEVnMPFzzxEiuRORmAdjrqBKV/I4E6B3G31qqA59/sJNXd0BEH1kHQDTqt X-Received: by 2002:a17:906:158c:: with SMTP id k12mr6687005ejd.119.1612419616827; Wed, 03 Feb 2021 22:20:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612419616; cv=none; d=google.com; s=arc-20160816; b=OCuwwKDA/fY9lpDhYDs6ux2+whZotEyta8NeZwrAKdwy2MSGvaChDjRcgwKxbQUWbS u1hgg44PhIdbk4HhQ6uQFzoTYpZFa5qveLkmPgvUGPsCZg9lS/cVFXIrwVxSzPeFl/Ab i6YDNs27qlEvH3ubXNK15yuwM12zzs1rOn/mRFDJeXP/KjtcgYJyihKrSSZhgFPTjPoH a4eJ5fndV0qZ8uA4hMeWi+0hIDdiXtAHIrOGuQ28a0ADrfXiWcuLpKOmsm4yR86RWzfp tPgQ1J8oiuclFzOisig6Dp0Kr0RWvE4aF0AP+c1nf8ec26jRxdzpZ3PnpKNqNF6rLQqn nujA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=di4/vrEwMGMptUjaosgJOlqFm8Mgh4qA8yfsVQbfl2E=; b=QJLcNqUvoQjVyA9yPr7GcCmlN6dQoT4zF+9T8R889sh9asAWt6CziDrA4Tt/+zyyIH MAtnwfjGNLolDV1dYucJVr7XM+6brmqDqRYJtT43sPjQyShrTjTg7DjpR0Rnd88HSG+Z eWhZSSLzLZAyTFMU26RxC2YClEv42nq/Z0LBhxyYWVtdlLtrrb8sMGsGzIRAFAj4hMcu 3j6Lemv//QSMJjD8BmK9ZdHsIC37J6EUYo6baJuhB6XRilFtzOfYPtyU0YmgyfZElx5I rtjeeninnF9UZ7wOPqhDEbv/cyl8K/TyjHxHFpseJGkMmK2GkMZHw5LNfNHxtHuLdnkH gOjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=rQhP2RFp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e6si3353517edz.362.2021.02.03.22.19.51; Wed, 03 Feb 2021 22:20:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=rQhP2RFp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231367AbhBDGQy (ORCPT + 99 others); Thu, 4 Feb 2021 01:16:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230270AbhBDGQw (ORCPT ); Thu, 4 Feb 2021 01:16:52 -0500 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91C94C0613ED for ; Wed, 3 Feb 2021 22:16:12 -0800 (PST) Received: by mail-pj1-x102f.google.com with SMTP id fa16so670398pjb.1 for ; Wed, 03 Feb 2021 22:16:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=di4/vrEwMGMptUjaosgJOlqFm8Mgh4qA8yfsVQbfl2E=; b=rQhP2RFpcACY1T51YL36IYgw+bupVCBeE/H3FN65jzK8OQr58VpTE1cuvZfj3mUHpR 4yg8DwXuY2T4X6k92CTY47xYpQXOeyU0b1lwLWHn4qr8/BFfRqGSYZOFvQ3rqHZ8M/DF JXYH+CihKBX+nM3UYLQRaV6e5yjCpprvQPRBczkPSr/J8HMISuJDwdBBt1J5ta3ZUzrA 0x9tvBToknGaRwF5bHfo9/tDphs7k6BXKgr4QCaNaBY2qUcDepL5/pNVK5xG54ua7W08 kVBnD3zlDo1hdrIbEi4PJH5Z214wS/huJzSbHCN3pbHab23GmKAZrsLFIJLpgWPcWnlV HrbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=di4/vrEwMGMptUjaosgJOlqFm8Mgh4qA8yfsVQbfl2E=; b=fJ/6PEeIEubwOI45sh/86JEtITeL9gG8MebovFBaO94dWLAQbs7w7qPNGeA2gZD/pX acuh6DJXHVWh5igwF+vdy2qEq80oy5liadgPDZ1UoJcM6ZiMrkPHML3arnpUx+XDPVFw W361Yq5s4AzD+29iWseTQEReM7HWWNNvtCHMbUDGhBqp8HUad7bfu9OVfXwKO9SX7kiP TIzZt/0StMDVE7l/ayDhDSL3ysAOesDehsoPeGm5WQRlhJxpanM6X3WVP4pHSB96SvhN P5ytoYUxEabhf5Uxtdm7EVqiWWv8CRnY59jsN7O71CODPVJtKZZBrRWyLzlKbcL6+rQx AYdA== X-Gm-Message-State: AOAM530PWymb4YST5UKGjKl3eqzxtAs3M8utTh5AV8/2M7T+AyIeBFJ1 EZxlrvduCXFwzEyiE3MAuRKQMWR04ibKk6MygCIWaw== X-Received: by 2002:a17:90a:db05:: with SMTP id g5mr7120354pjv.32.1612419371984; Wed, 03 Feb 2021 22:16:11 -0800 (PST) MIME-Version: 1.0 References: <20210130004401.2528717-1-ndesaulniers@google.com> <20210130004401.2528717-2-ndesaulniers@google.com> <20210130015222.GC2709570@localhost> In-Reply-To: From: Nick Desaulniers Date: Wed, 3 Feb 2021 22:15:59 -0800 Message-ID: Subject: Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice To: Masahiro Yamada Cc: Nathan Chancellor , Nathan Chancellor , Andrew Morton , Sedat Dilek , Linux Kernel Mailing List , clang-built-linux , Linux Kbuild mailing list , linux-arch , Jakub Jelinek , Fangrui Song , Caroline Tice , Nick Clifton , Yonghong Song , Jiri Olsa , Andrii Nakryiko , Arnaldo Carvalho de Melo , Arvind Sankar Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 3, 2021 at 4:30 PM Masahiro Yamada wrote: > > On Thu, Feb 4, 2021 at 8:16 AM Nick Desaulniers wrote: > > > > On Wed, Feb 3, 2021 at 2:24 PM Masahiro Yamada wrote: > > > > > > On Sat, Jan 30, 2021 at 10:52 AM Nathan Chancellor wrote: > > > > > > > > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > > > > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is > > > > > the default. Does so in a way that's forward compatible with existing > > > > > configs, and makes adding future versions more straightforward. > > > > > > > > > > GCC since ~4.8 has defaulted to this DWARF version implicitly. > > > > > > > > > > Suggested-by: Arvind Sankar > > > > > Suggested-by: Fangrui Song > > > > > Suggested-by: Nathan Chancellor > > > > > Suggested-by: Masahiro Yamada > > > > > Signed-off-by: Nick Desaulniers > > > > > > > > One comment below: > > > > > > > > Reviewed-by: Nathan Chancellor > > > > > > > > > --- > > > > > Makefile | 5 ++--- > > > > > lib/Kconfig.debug | 16 +++++++++++----- > > > > > 2 files changed, 13 insertions(+), 8 deletions(-) > > > > > > > > > > diff --git a/Makefile b/Makefile > > > > > index 95ab9856f357..d2b4980807e0 100644 > > > > > --- a/Makefile > > > > > +++ b/Makefile > > > > > @@ -830,9 +830,8 @@ ifneq ($(LLVM_IAS),1) > > > > > KBUILD_AFLAGS += -Wa,-gdwarf-2 > > > > > > > > It is probably worth a comment somewhere that assembly files will still > > > > have DWARF v2. > > > > > > I agree. > > > Please noting the reason will be helpful. > > > > Via a comment in the source, or in the commit message? > > > > > > > > Could you summarize Jakub's comment in short? > > > https://patchwork.kernel.org/project/linux-kbuild/patch/20201022012106.1875129-1-ndesaulniers@google.com/#23727667 > > > > Via a comment in the source, or in the commit message? > > > Both in the source if you can summarize it in three lines or so. > > > If you need to add more detailed explanation, > please provide it in the commit log. This information is mostly in the commit log of patch 2. I will reword it with additional info from the link you sent, but I find that such minutiae is resulting in diminishing returns on subsequent respins of the patch series. I implore you to reword v8 (which I will send) as you see fit when applying the series. -- Thanks, ~Nick Desaulniers