Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Sven Schuchmann <schuchmann@schleissheimer.de>
To:     Pavel Machek <pavel@ucw.cz>, Marek Behun <marek.behun@nic.cz>
CC:     Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org>,
        "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: AW: [PATCH v1] leds: lp50xx: add setting of default intensity from DT
Thread-Topic: [PATCH v1] leds: lp50xx: add setting of default intensity from
 DT
Thread-Index: AQHW7lFOn/1Jlt56EkOy+ZVk/3cx2qpGlWAAgAAP4bCAABNlgIAADMWAgAAAZQCAAOw7kA==
Date:   Thu, 4 Feb 2021 07:31:26 +0000
Message-ID: <DB8P190MB0634002C60A8680823421A69D9B39@DB8P190MB0634.EURP190.PROD.OUTLOOK.COM>
References: <20210119105312.2636-1-schuchmann@schleissheimer.de>
 <20210203142940.GB12369@duo.ucw.cz>
 <DB8P190MB06348FC85033135BFC3EF5C4D9B49@DB8P190MB0634.EURP190.PROD.OUTLOOK.COM>
 <20210203163555.GA23019@duo.ucw.cz> <20210203182137.339f8470@nic.cz>
 <20210203172302.GB23019@duo.ucw.cz>
In-Reply-To: <20210203172302.GB23019@duo.ucw.cz>
Accept-Language: de-DE, en-US
Content-Language: de-DE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d18f31a-9135-4e66-1fff-08d8c8dee17c
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2021 07:31:26.3411
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: ba05321a-a007-44df-8805-c7e62d5887b5
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: P8A9q/h59dWLb8jx+H+ekYtUd/74zfTT/JFf4Gwzy102ZxrdvsUxXo4WeiqPWyhMXyubMw1jyxEwdS48zHqQpRxWHcvc9smfzou7870QF3Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6P190MB0054
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Pavel, hello Marek

> > Is the property default-intensity documented in DT bindings?

I updated the documentation in leds-lp50xx.yaml. Is it this what you mean?

> > Wouldn't it be better if the property was used in the multi-led node
> > instead of the channel node? I.e.
> >   multi-led@3 {
> >     color =3D <LED_COLOR_ID_RGB>;
> >     default-intensity =3D <100 0 0>;
> >   };
>=20
> Yes, this would be better.

Sound good, I will see what I can do here.

Regards, Sven