Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp923238pxb; Thu, 4 Feb 2021 00:02:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJzUOe0H+c1sMxiirrytsdDwGykCV3dOBG982gQ/zXROWjaTqTzmv22YEZnLd7AQaiChbPh3 X-Received: by 2002:a17:906:2353:: with SMTP id m19mr7034182eja.13.1612425773942; Thu, 04 Feb 2021 00:02:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612425773; cv=none; d=google.com; s=arc-20160816; b=urNdM1JnaaNG3yF/sSaAAlAfLHaoXek0foYQh1UDNqIPbSpJbhM/vrAUbW6oczoZvs WrtqKU9esnRaApWLfnY6w4W9u4Ydp/8hwIRGyAP9XEyp/HKb/1VY9V1vHcY1M0BwDakv 8vAt/aPKkKQ7ruiElgJyoP6URc7jI2RiqLSOyZF6j3CzErEY7V//PgHIZ3ZziJjoF2EV xWgJhgMhVpHuKVlj7WqAyDAOdjXecYmfyKX2DT+28GiULN5Q0VuS/qKEgM0iaFl2OLBm BZ6sk326HuXPqbVsIxy199E6XaIt/ZjpXJeCsZALu/ufnLIiZqFnJsOhEbPca7DcZAiv 04tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=QBsXoruAAtsJuosf97KoKNbhLVB29QKk464/inmtI84=; b=L8Pt3VoZWO+Fwd61/kxroF/bOGRpQLuQK9QzTdq0vZgEk6pHYyJuTyZKfzlRAfAzzI SHAk8X3RC6FqDPcD9xq2/GgLFiunIRocfvPhzPCkw5ijYgbkdQuzhF711QF2Hcks+3o8 ZHFQ51opnKUvUc/A3j6c5iwSN8R9qszLclxna6e6P36uU2ITOzTekBqKh3TYQZbM9OrA JU6cfH3iBXRYdSi1feTAceO/+IDq8OvkcXfi9PbSDMUApA7pOR49iAsAGNQ0lZBhfQkO EmSvYtpkE5ZXVpzGP+xbQruz/5aQTfRIapcSAE/jydut//nCDLSLVtv045zvij7YZlsQ qYFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b8si2862583eds.433.2021.02.04.00.02.29; Thu, 04 Feb 2021 00:02:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233460AbhBDIBD (ORCPT + 99 others); Thu, 4 Feb 2021 03:01:03 -0500 Received: from out30-131.freemail.mail.aliyun.com ([115.124.30.131]:60174 "EHLO out30-131.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230252AbhBDIBC (ORCPT ); Thu, 4 Feb 2021 03:01:02 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R931e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UNpwIFV_1612425610; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UNpwIFV_1612425610) by smtp.aliyun-inc.com(127.0.0.1); Thu, 04 Feb 2021 16:00:16 +0800 From: Jiapeng Chong To: stf_xl@wp.pl Cc: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] iwlegacy: 4965-mac: Simplify the calculation of variables Date: Thu, 4 Feb 2021 16:00:08 +0800 Message-Id: <1612425608-40450-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warnings: ./drivers/net/wireless/intel/iwlegacy/4965-mac.c:2596:54-56: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/net/wireless/intel/iwlegacy/4965-mac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c index 28675a4..52db532 100644 --- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c +++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c @@ -2593,8 +2593,7 @@ struct il_mod_params il4965_mod_params = { */ if (ret != IL_INVALID_STATION && (!(il->stations[ret].used & IL_STA_UCODE_ACTIVE) || - ((il->stations[ret].used & IL_STA_UCODE_ACTIVE) && - (il->stations[ret].used & IL_STA_UCODE_INPROGRESS)))) { + (il->stations[ret].used & IL_STA_UCODE_INPROGRESS))) { IL_ERR("Requested station info for sta %d before ready.\n", ret); ret = IL_INVALID_STATION; -- 1.8.3.1