Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1057711pxb; Thu, 4 Feb 2021 04:09:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJwqdWfHbM1wCTddSKntNdBD91Nglnrt0kK6dkkdaGqHms4vuTRycP8M7EqGeB0AdYXXv9AJ X-Received: by 2002:a17:906:248e:: with SMTP id e14mr7610975ejb.495.1612440579020; Thu, 04 Feb 2021 04:09:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612440579; cv=none; d=google.com; s=arc-20160816; b=TcLKw+QvbhT7EijAx6rYwHL0wXAZC+uLdQZbOO/dg7e+qSFeWYYl6XYTDFGWD/26TP FyYKQGEzatusR6QFBSaTWXJ15C+2PQrkYaG5aoOxNDY3y7Auo5C9vc7MvMcUC5Mv9Gdx 7b+cq12zf76KE8g+NU0v9SCIgwZraRL3a0vFZXwi+M8GLzs3VPuz4gywEw2k+pUqyHpv CsAOpoWmvoLH31qzv9xzxKH4Vm+vhIoxEJP3y4wtIbPZCg8Tq+f5aUycvoAgi6/gFVx8 uSTPMB+CRNJ+c/ON2idA/PFq4jDm51bA8tVLU/MAdISjJIdppzFBOj6yZW8GftZvUY/+ sLKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=Zas4xrrRYXn01c29TYJZytqxMsGAb43t1Bg8e5vmv3k=; b=VXOBPp29h2oWhsNj15kvY8Fj4wkTHHbwOjQWML//7FF+1JlsUJ6dtMpwXB+b+JWBjL Sc0LBxuxRY7WR1V4VvK48caW9etlAc6Fp7rOdrboODVABr0UOvqqBQbAoLjhHXV7XmJJ ZCE1ZTHQecBMDBJHhEJSc4jc7NtQkdvg6Pkrs6fMIFTR2woEYdDRL7AnKPE5epIyov1I G95CWh57NLNRuky2uvtqKo3U5Mt3ELZ/8n7fCeMsPvFumdIGL7a8fv5TBpdtROPAN1rJ bj7ajENYe1pTN5SUqBzktRdsr09vzwUbNa+dhr9ZdAMM05Ldo/JYClFbohG4waFcOTSI 6SAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b11si2923083ede.511.2021.02.04.04.09.13; Thu, 04 Feb 2021 04:09:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235745AbhBDMEh (ORCPT + 99 others); Thu, 4 Feb 2021 07:04:37 -0500 Received: from foss.arm.com ([217.140.110.172]:57122 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235578AbhBDMEg (ORCPT ); Thu, 4 Feb 2021 07:04:36 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B6CD6D6E; Thu, 4 Feb 2021 04:03:50 -0800 (PST) Received: from [192.168.178.6] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AA3343F73B; Thu, 4 Feb 2021 04:03:48 -0800 (PST) Subject: Re: [PATCH 0/8] sched/fair: misfit task load-balance tweaks To: Valentin Schneider , Qais Yousef Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Vincent Guittot , Morten Rasmussen , Quentin Perret , Pavan Kondeti , Rik van Riel References: <20210128183141.28097-1-valentin.schneider@arm.com> <20210203151400.ommltjjyuok4yj5e@e107158-lin> From: Dietmar Eggemann Message-ID: <66efcfb1-d6ee-248a-e337-d690cda1bb5a@arm.com> Date: Thu, 4 Feb 2021 13:03:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/02/2021 19:43, Valentin Schneider wrote: > Hi Qais, > > On 03/02/21 15:14, Qais Yousef wrote: >> On 01/28/21 18:31, Valentin Schneider wrote: >>> Hi folks, >>> >>> Here is this year's series of misfit changes. On the menu: >>> >>> o Patch 1 is an independent active balance cleanup >>> o Patch 2 adds some more sched_asym_cpucapacity static branches >>> o Patch 3 introduces yet another margin for capacity to capacity >>> comparisons >>> o Patches 4-6 build on top of patch 3 and change capacity comparisons >>> throughout misfit load balancing >>> o Patches 7-8 fix some extra misfit issues I've been seeing on "real" >>> workloads. >>> >>> IMO the somewhat controversial bit is patch 3, because it attempts to solve >>> margin issues by... Adding another margin. This does solve issues on >>> existing platforms (e.g. Pixel4), but we'll be back to square one the day >>> some "clever" folks spin a platform with two different CPU capacities less than >>> 5% apart. >> >> One more margin is a cause of apprehension to me. But in this case I think it >> is the appropriate thing to do now. I can't think of a scenario where this >> could hurt. >> > > Thanks for having a look! > >> Thanks >> >> -- >> Qais Yousef How did you verify the benefit of these changes? It's clear that you need a platform with capacity_orig diffs <20% between CPU types (like Pixel4 - SD855 (4x261, 3x871, 1x1024) or QC's RB5 platform - SD865 (4x284, 3x871, 1*1024)) but which benchmark/testcase did you use?