Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 4 Feb 2021 09:58:19 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Ian Rogers <irogers@google.com>,
        Stephane Eranian <eranian@google.com>,
        Alexei Budankov <abudankov@huawei.com>
Subject: Re: [PATCH 06/24] perf daemon: Add config file support
Message-ID: <20210204125819.GA910119@kernel.org>
References: <20210129134855.195810-1-jolsa@redhat.com>
 <20210130234856.271282-1-jolsa@kernel.org>
 <20210130234856.271282-7-jolsa@kernel.org>
 <CAM9d7cjuPHh6j2H5-M-5=4MSujoJH7rWUYwKbypOk7_Jt-6QTg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAM9d7cjuPHh6j2H5-M-5=4MSujoJH7rWUYwKbypOk7_Jt-6QTg@mail.gmail.com>
Precedence: bulk

Em Thu, Feb 04, 2021 at 09:42:35PM +0900, Namhyung Kim escreveu:
> Hi Jiri,
> 
> On Sun, Jan 31, 2021 at 8:49 AM Jiri Olsa <jolsa@kernel.org> wrote:
> [SNIP]
> > +#define SESSION_OUTPUT  "output"
> > +
> > +/*
> > + * Session states:
> > + *
> > + *   OK       - session is up and running
> > + *   RECONFIG - session is pending for reconfiguration,
> > + *              new values are already loaded in session object
> > + *   KILL     - session is pending to be killed
> > + *
> > + * Session object life and its state is maintained by
> > + * following functions:
> > + *
> > + *  setup_server_config
> > + *    - reads config file and setup session objects
> > + *      with following states:
> > + *
> > + *      OK       - no change needed
> > + *      RECONFIG - session needs to be changed
> > + *                 (run variable changed)
> > + *      KILL     - session needs to be killed
> > + *                 (session is no longer in config file)
> > + *
> > + *  daemon__reconfig
> > + *    - scans session objects and does following actions
> > + *      for states:
> > + *
> > + *      OK       - skip
> > + *      RECONFIG - session is killed and re-run with new config
> > + *      KILL     - session is killed
> > + *
> > + *    - all sessions have OK state on the function exit
> > + */
> > +enum session_state {
> > +       SESSION_STATE__OK,
> > +       SESSION_STATE__RECONFIG,
> > +       SESSION_STATE__KILL,
> > +};
> > +
> > +struct session {
> > +       char                    *base;
> > +       char                    *name;
> > +       char                    *run;
> > +       int                      pid;
> > +       struct list_head         list;
> > +       enum session_state       state;
> > +};
> 
> Although I think calling it 'session' is intuitive, it's also confusing
> as we already have struct perf_session...

Maybe 'struct server_session' ? If this ends up in tools/lib/perf, then
it gets renamed to 'struct perf_server_session', just like we have
'struct perf_evsel' in libperf and 'struct evsel' in tools/perf/, right?

- Arnaldo