Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 4 Feb 2021 15:51:11 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Ian Rogers <irogers@google.com>,
        Stephane Eranian <eranian@google.com>,
        Alexei Budankov <abudankov@huawei.com>
Subject: Re: [PATCH 07/24] perf daemon: Add config file change check
Message-ID: <YBwJ36m11cVh5G+u@krava>
References: <20210129134855.195810-1-jolsa@redhat.com>
 <20210130234856.271282-1-jolsa@kernel.org>
 <20210130234856.271282-8-jolsa@kernel.org>
 <20210203211359.GT854763@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210203211359.GT854763@kernel.org>
Precedence: bulk

On Wed, Feb 03, 2021 at 06:13:59PM -0300, Arnaldo Carvalho de Melo wrote:

SNIP

> >  #include <sys/types.h>
> >  #include <sys/socket.h>
> >  #include <sys/un.h>
> > @@ -73,6 +75,7 @@ struct session {
> >  struct daemon {
> >  	const char		*config;
> >  	char			*config_real;
> > +	char			*config_base;
> >  	const char		*base_user;
> >  	char			*base;
> >  	struct list_head	 sessions;
> > @@ -493,6 +496,7 @@ static void daemon__free(struct daemon *daemon)
> >  		session__remove(session);
> >  
> >  	free(daemon->config_real);
> > +	free(daemon->config_base);
> >  	free(daemon->base);
> 
> Please replace those with zfree()

ok

> 
> >  }
> >  
> > @@ -535,6 +539,83 @@ static int daemon__reconfig(struct daemon *daemon)
> >  	return 0;
> >  }
> >  
> > +static int setup_config_changes(struct daemon *daemon)
> > +{
> > +	char *basen = strdup(daemon->config_real);
> > +	char *dirn  = strdup(daemon->config_real);
> > +	char *base, *dir;
> > +	int fd, wd;
> > +
> > +	if (!dirn || !basen)
> > +		return -ENOMEM;
> 
> This may leak one of them

right, will fix

thanks,
jirka