Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 4 Feb 2021 16:58:23 +0200
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Stefan Berger <stefanb@linux.ibm.com>,
        Saulo Alessandre <saulo.alessandre@gmail.com>,
        keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
        davem@davemloft.net, dhowells@redhat.com, zohar@linux.ibm.com,
        linux-kernel@vger.kernel.org, patrick@puiterwijk.org,
        linux-integrity@vger.kernel.org
Subject: Re: [PATCH v7 1/4] crypto: Add support for ECDSA signature
 verification
Message-ID: <YBwLj+8kHIHMA3xH@kernel.org>
References: <20210201151910.1465705-1-stefanb@linux.ibm.com>
 <20210201151910.1465705-2-stefanb@linux.ibm.com>
 <20210204052738.GA7086@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210204052738.GA7086@gondor.apana.org.au>
Precedence: bulk

On Thu, Feb 04, 2021 at 04:27:39PM +1100, Herbert Xu wrote:
> On Mon, Feb 01, 2021 at 10:19:07AM -0500, Stefan Berger wrote:
> > Add support for parsing the parameters of a NIST P256 or NIST P192 key.
> > Enable signature verification using these keys. The new module is
> > enabled with CONFIG_ECDSA:
> >   Elliptic Curve Digital Signature Algorithm (NIST P192, P256 etc.)
> >   is A NIST cryptographic standard algorithm. Only signature verification
> >   is implemented.
> > 
> > Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: linux-crypto@vger.kernel.org
> > ---
> >  crypto/Kconfig               |  10 +
> >  crypto/Makefile              |   6 +
> >  crypto/ecc.c                 |  13 +-
> >  crypto/ecc.h                 |  28 +++
> >  crypto/ecdsa.c               | 361 +++++++++++++++++++++++++++++++++++
> >  crypto/ecdsasignature.asn1   |   4 +
> >  crypto/testmgr.c             |  12 ++
> >  crypto/testmgr.h             | 267 ++++++++++++++++++++++++++
> >  include/linux/oid_registry.h |   4 +
> >  9 files changed, 694 insertions(+), 11 deletions(-)
> >  create mode 100644 crypto/ecdsa.c
> >  create mode 100644 crypto/ecdsasignature.asn1


Acked-by: Jarkko Sakkinen <jarkko@kernel.org>

Great, ECDSA has been lacking for a way too long. Just wanted to
acknowledge support for this, I just now also skimmed the change
from patchwrok (way too quickly for reviewed-by but well enough
for ack).

/Jarkko