Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 4 Feb 2021 12:53:24 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Ian Rogers <irogers@google.com>,
        Stephane Eranian <eranian@google.com>,
        Alexei Budankov <abudankov@huawei.com>
Subject: Re: [PATCH 04/24] perf daemon: Add server socket support
Message-ID: <20210204155324.GC910119@kernel.org>
References: <20210129134855.195810-1-jolsa@redhat.com>
 <20210130234856.271282-1-jolsa@kernel.org>
 <20210130234856.271282-5-jolsa@kernel.org>
 <20210203210423.GQ854763@kernel.org>
 <YBwJgC4QX5re1VNw@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YBwJgC4QX5re1VNw@krava>
Precedence: bulk

Em Thu, Feb 04, 2021 at 03:49:36PM +0100, Jiri Olsa escreveu:
> On Wed, Feb 03, 2021 at 06:04:23PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Sun, Jan 31, 2021 at 12:48:36AM +0100, Jiri Olsa escreveu:
> > > +static int setup_server_socket(struct daemon *daemon)
> > > +{
> > > +	struct sockaddr_un addr;
> > > +	char path[100];
> > > +	int fd;
> > > +
> > > +	fd = socket(AF_UNIX, SOCK_STREAM, 0);
> > 
> > Minor, combine decl with use, since line isn't long and its one after
> > the other, i.e.:
> > 
> > 	int fd = socket(AF_UNIX, SOCK_STREAM, 0);
> 
> hum, sure, but I'm missing the point.. I think it's less readable

one line instead of three :-)
 
> > 
> > > +	if (fd < 0) {
> > > +		fprintf(stderr, "socket: %s\n", strerror(errno));
> > > +		return -1;

- Arnaldo