Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 4 Feb 2021 15:56:35 +0000
From:   Daniel Thompson <daniel.thompson@linaro.org>
To:     Stephen Zhang <stephenzhangzsd@gmail.com>
Cc:     jason.wessel@windriver.com, dianders@chromium.org,
        gustavoars@kernel.org, kgdb-bugreport@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] kdb: kdb_support: Fix debugging information problem
Message-ID: <20210204155635.ibvnyzo7qqgysfhl@maple.lan>
References: <1612440429-6391-1-git-send-email-stephenzhangzsd@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1612440429-6391-1-git-send-email-stephenzhangzsd@gmail.com>
Precedence: bulk

On Thu, Feb 04, 2021 at 08:07:09PM +0800, Stephen Zhang wrote:
> There are several common patterns.
> 
> 0:
>         kdb_printf("...",...);
> 
> which is the normal one.
> 
> 1:
>         kdb_printf("%s: "...,__func__,...)
> 
> We could improve '1' to this :
> 
>         #define kdb_func_printf(format, args...) \
>                    kdb_printf("%s: " format, __func__, ## args)
> 
> 2:
>         if(KDB_DEBUG(AR))
>                 kdb_printf("%s "...,__func__,...);
> 
> We could improve '2' to this :
>         #define kdb_dbg_printf(mask, format, args...) \
>                            do { \
>                                         if (KDB_DEBUG(mask)) \
>                                                 kdb_func_printf(format, ## args); \

This line is picked up by checkpatch as being overlong.

>                            } while (0)
> 
> In additon, we changed the format code of size_t to %zu.

Should be `addition`.


> Signed-off-by: Stephen Zhang <stephenzhangzsd@gmail.com>

It is arguable that there should be a Reviewed-by: from Doug here...
although given the big changes in v3 I don't think you were wrong
to drop it.

Nevertheless... given the implicit R-b ("when Daniel merges") in Doug's
comments on v3 I decided to reinstate it.

No action needed from you on this. I have fixed up all these issues
when I applied the patch. Thanks!


Daniel.