Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1234399pxb; Thu, 4 Feb 2021 08:03:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJxN0zVCRnnFju+EY+WBkSRjG2hkKYi1chkah4yT9dXJakmv3C2bsQZV2Gb/QXH9Y5gG+gGX X-Received: by 2002:a17:906:f854:: with SMTP id ks20mr7216721ejb.50.1612454633709; Thu, 04 Feb 2021 08:03:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612454633; cv=none; d=google.com; s=arc-20160816; b=SN0DsDspaydPvwZ0CGGISdgfGGU8jqoBZRIoopePDLWI8+ysZEzbPdG7WHX7Yb9dyh Y1P69S2xngyGkaHuV8xpI+1+ANvwa+P4g4W/C7QNMCA8h9/majawKEAtyLAu9XDy+9m1 YJ7QBrvegJP5rkOzwujRjK0uTYXC8dsV3PJakN51P359f9i7pviceyTSIyc/1JCLaszL lWzeFbHosYSq+WusV/KI4yAkWmR73WltvCXcjow7LPeJ6872SPrMjUphTSXEwX6ULClf cmtlcXUbQ3ReEovgB9NOP/NtkncdQdZ/53JXpDb2/S0BelRsVZRLMZAQwmugZ3R0KBp8 p7Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=etT7X4K+k0BfrP2kEIs+zpn4CYM9jnwbFRYIw/Vpixw=; b=TbAxAhIj5g9Ob7q9hsECn3xf3qIorb5bEUi2Zyy14dvD5UeyicKfhHA+o2cIe8l8x2 4kzwEQNZsUmVTw2LE4d4TiVZGpH88WJAekprY3VM7VgHxV8oNcePjytuuYkBE3cIP+e5 suYwDGfUSMuc2wzgUByQSCL6KlnqLO+AGNk3MDPw6a9A/+lHB3iovO5X1EM9f1llUags KBhYR0lGOHzam9ENsQuMULBLnJP6FDR46GtZyuJ0/xUI2BtacluP/pvQ2RSiduAaMRMM JwHmlrGaND3E9RdouJdKcPi7bz02vMSEEneKtPh+/tCvhK0p3betYo9FlreyqWdONxIM lfMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w17si3432530ejb.223.2021.02.04.08.03.26; Thu, 04 Feb 2021 08:03:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237544AbhBDQAX (ORCPT + 99 others); Thu, 4 Feb 2021 11:00:23 -0500 Received: from mail-ot1-f53.google.com ([209.85.210.53]:46432 "EHLO mail-ot1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237695AbhBDP7p (ORCPT ); Thu, 4 Feb 2021 10:59:45 -0500 Received: by mail-ot1-f53.google.com with SMTP id d1so3813404otl.13; Thu, 04 Feb 2021 07:59:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=etT7X4K+k0BfrP2kEIs+zpn4CYM9jnwbFRYIw/Vpixw=; b=Kj7q/y/6JtcVSYS6Dsw/3Ix3o/eVDnfa2UD/GiYSDNvYNKX+/v3Y5xx4T6tiOeNezN LWBKP1kYhFOu4RJYSZ+PTP45HvJbtc5HKAyO/CSAYwz0wNTcuOsQ4gwx6yRE1lagsjLz SwR69u3PvdVfeFUW3rXjiMBYAtU/i210zE1clNHWU7w4bGmW/VSifShUi758HwU5hb0j 9LJEAXAy/hWcHBGQ7JHSUdTYviY4e7IEBBDMWju/pIOIwrjFvtYxc0Fw+SLowZCciPZg bQ/UQdo/W3gfa8ccpChNNS43wUoGLff8HeOuk0k42xdAjhVElPPUgnkRT/fHFmY4BTok kzIg== X-Gm-Message-State: AOAM531/u4c8AfXpOB1g7S6dTgkrPuXMxgDcpm1EFDu8ODgscQ9VMrjS WEYZJhSkuBkhwETh/Zi7SMCORVRBYw== X-Received: by 2002:a9d:5f0b:: with SMTP id f11mr5820687oti.263.1612454341191; Thu, 04 Feb 2021 07:59:01 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id g13sm1174935otl.60.2021.02.04.07.58.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 07:59:00 -0800 (PST) Received: (nullmailer pid 521229 invoked by uid 1000); Thu, 04 Feb 2021 15:58:59 -0000 Date: Thu, 4 Feb 2021 09:58:59 -0600 From: Rob Herring To: Viresh Kumar Cc: Pantelis Antoniou , David Gibson , Masahiro Yamada , Frank Rowand , Vincent Guittot , anmar.oueja@linaro.org, linux-kernel@vger.kernel.org, Bill Mills , Michal Marek , Rob Herring , linux-kbuild@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH V7 0/6] dt: build overlays Message-ID: <20210204155859.GB519221@robh.at.kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Jan 2021 12:54:04 +0530, Viresh Kumar wrote: > Hi, > > This patchset makes necessary changes to the kernel to add support for > building overlays (%.dtbo) and the required fdtoverlay tool. This also > builds static_test.dtb using most of the existing overlay tests present > in drivers/of/unittest-data/ for better test coverage. > > Note that in order for anyone to test this stuff, you need to manually > run the ./update-dtc-source.sh script once to fetch the necessary > changes from the external DTC project (i.e. fdtoverlay.c and this[1] > patch). > > I have tested this patchset for static and runtime testing (on Hikey > board) and no issues were reported. > > V7: > - Add a comment in scripts/dtc/Makefile > - Add Ack from Masahiro for patch 4/6. > - Drop word "merge" from commit log of 2/6. > - Split apply_static_overlay, static_test.dtb, and static_base.dts into > two parts to handle overlay_base.dts and testcases.dts separately. > > V6: > - Create separate rules for dtbo-s and separate entries in .gitignore in > 4/6 (Masahiro). > - A new file layout for handling all overlays for existing and new tests > 5/6 (Frank). > - Include overlay.dts as well now in 6/6 (Frank). > > V5: > > - Don't reuse DTC_SOURCE for fdtoverlay.c in patch 1/5 (Frank). > > - Update .gitignore and scripts/Makefile.dtbinst, drop dtbo-y syntax and > DTC_FLAGS += -@ in patch 4/5 (Masahiro). > > - Remove the intermediate dtb, rename output to static_test.dtb, don't > use overlay.dtb and overlay_base.dtb for static builds, improved > layout/comments in Makefile for patch 5/5 (Frank). > > -- > Viresh > > [1] https://github.com/dgibson/dtc/commit/163f0469bf2ed8b2fe5aa15bc796b93c70243ddc > [2] https://lore.kernel.org/lkml/74f8aa8f-ffab-3b0f-186f-31fb7395ebbb@gmail.com/ > > Viresh Kumar (6): > scripts: dtc: Fetch fdtoverlay.c from external DTC project > scripts: dtc: Build fdtoverlay tool > scripts: dtc: Remove the unused fdtdump.c file > kbuild: Add support to build overlays (%.dtbo) > of: unittest: Create overlay_common.dtsi and testcases_common.dtsi > of: unittest: Statically apply overlays using fdtoverlay I've applied the first 4 patches and did a dtc sync after patch 1. Rob