Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Jonas Mark (BT-FIR/ENG1-Grb)" <Mark.Jonas@de.bosch.com>
To:     Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
        Support Opensource <Support.Opensource@diasemi.com>,
        Lee Jones <lee.jones@linaro.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Steve Twiss <stwiss.opensource@diasemi.com>,
        "marek.vasut@gmail.com" <marek.vasut@gmail.com>,
        "RUAN Tingquan (BT-FIR/ENG1-Zhu)" <Tingquan.Ruan@cn.bosch.com>,
        "Streidl Hubert (BT-FIR/ENG1-Grb)" <Hubert.Streidl@de.bosch.com>,
        Wolfram Sang <wsa@kernel.org>
Subject: AW: [PATCH v2] mfd: da9063: Support SMBus and I2C mode
Thread-Topic: [PATCH v2] mfd: da9063: Support SMBus and I2C mode
Thread-Index: AQHW+w22q4v1gg8dsUO4hgmyCKHsCKpIGVsAgAATqNA=
Date:   Thu, 4 Feb 2021 16:20:18 +0000
Message-ID: <75c383e09ba74ca2af98d01b9470f53d@de.bosch.com>
References: <20210204155201.120524-1-mark.jonas@de.bosch.com>
 <PR3PR10MB41426B0114614DED4C2687F880B39@PR3PR10MB4142.EURPRD10.PROD.OUTLOOK.COM>
In-Reply-To: <PR3PR10MB41426B0114614DED4C2687F880B39@PR3PR10MB4142.EURPRD10.PROD.OUTLOOK.COM>
Accept-Language: de-DE, en-US
Content-Language: de-DE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

Hi Adam,

> > +	if (i2c_check_functionality(i2c->adapter, I2C_FUNC_I2C)) {
> > +		dev_info(da9063->dev, "I2C mode");
> > +		busmode =3D 0;
> > +	} else {
> > +		dev_info(da9063->dev, "SMBus mode");
> > +		busmode =3D 1;
>=20
> I think this should be 'DA9063_TWOWIRE_TO' rather than '1' otherwise I th=
ink
> you'll be setting 0 still here as it doesn't match up with the mask.

You are right. We need to fix this and send a new patch.

> > +	}
> > +	ret =3D regmap_update_bits(da9063->regmap,
> DA9063_REG_CONFIG_J,
> > +		DA9063_TWOWIRE_TO, busmode);
> > +	if (ret < 0) {
> > +		dev_err(da9063->dev, "Failed to set 2-wire bus mode.\n");
> > +		return -EIO;
> > +	}
> > +
> >  	return da9063_device_init(da9063, i2c->irq);  }
> >
> > diff --git a/include/linux/mfd/da9063/registers.h
> > b/include/linux/mfd/da9063/registers.h
> > index 1dbabf1b3cb8..6e0f66a2e727 100644
> > --- a/include/linux/mfd/da9063/registers.h
> > +++ b/include/linux/mfd/da9063/registers.h
> > @@ -1037,6 +1037,9 @@
> >  #define		DA9063_NONKEY_PIN_AUTODOWN	0x02
> >  #define		DA9063_NONKEY_PIN_AUTOFLPRT	0x03
> >
> > +/* DA9063_REG_CONFIG_J (addr=3D0x10F) */
> > +#define DA9063_TWOWIRE_TO			0x40
> > +
> >  /* DA9063_REG_MON_REG_5 (addr=3D0x116) */
> >  #define DA9063_MON_A8_IDX_MASK			0x07
> >  #define		DA9063_MON_A8_IDX_NONE		0x00
> > --
> > 2.25.1

Cheers,
Mark