Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1315167pxb; Thu, 4 Feb 2021 09:47:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJz6wZrXRoVaGNnRvMJ0564w2f37MXlQd+j79ly097Xc6m/OXrRbj8A53PR5Ra7MpQvbU8RA X-Received: by 2002:aa7:c895:: with SMTP id p21mr92003eds.165.1612460857484; Thu, 04 Feb 2021 09:47:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612460857; cv=none; d=google.com; s=arc-20160816; b=tzLfvPf9mw19xRI7Tg/p8iea2uOfNNPYz9kmdeoupa5cC7kJEr/w0Kchp9mw8GiYW/ PUdguqahwioArWhd3Nl3mHKozbqLnRae9fmsZbQpEwUK9EmPWrGO7+JDRfx4APSID94S wBustaIc4JYzO9UAL4XvSVNDZau7yKOqBvGtcx++IZI5DS1YDKOUXxsoPFJzPELNtRWO ovmiAvttvxE6x2I246ApywLMbKHkWCSQul5lDwNSw9GCRl5JfrNTupVptnld7gqq77Qz JqkVoPQQVgFKtRaXe3ppK+kD9PdMV2ncPC4BiRErNN/ci4fRUS1WoCAw6HjtH3Q02gD4 Nj7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GCBGFufjjtkKM79QaCqD4gnNbGr/Jp0wwB8/7DPDEJI=; b=prJw2MKgFSzZyyQVILScQM2le/DWe88dJE9FMok11cE0z9kO72VJp2X3oh1sLubUj9 l/mXJR9QoOtr2CBLfFqJ3FM6vn+J75ORsMumKvLr4b/1Y8SBgGKTHax2xQfaRdC2m3LN QmFvjobFvFmLzPGn6FgiHUv908bzO6SsposbGgOspQsgAIjTNgJo11O1jsH+sMUa9m2C /xaSY7rU8r6cchHSxeMBPO7BwVQgG1HGjpgrxny6QZzdhxSkt784RCDXKWoWP7orRKEB pb1Jr45phMjRVxfUwe7yATifaTpaCra9cbgL9cKxKOmFlxI6H2KbIjtwCltSlGJsZYiK qVWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=kNmXSlAA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f1si3428823ejd.696.2021.02.04.09.47.11; Thu, 04 Feb 2021 09:47:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=kNmXSlAA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238493AbhBDRpQ (ORCPT + 99 others); Thu, 4 Feb 2021 12:45:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238581AbhBDRoi (ORCPT ); Thu, 4 Feb 2021 12:44:38 -0500 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C28D7C0613D6 for ; Thu, 4 Feb 2021 09:43:58 -0800 (PST) Received: by mail-qk1-x72d.google.com with SMTP id r77so4095550qka.12 for ; Thu, 04 Feb 2021 09:43:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GCBGFufjjtkKM79QaCqD4gnNbGr/Jp0wwB8/7DPDEJI=; b=kNmXSlAAZOA5BA1Nd/FHNTmnZuUl+kBcrKvgz0V3T9PaqZLDkAdiv+vpuvjGJWzgIQ 1JbP6ozldUU5i9up9n52QDgGGYGoDr2vLQPsW3ypPSvSxzf47qEyMaHhjlht+j+pN+Am 0SC3HBoEE2tK35rFDjrbYwH6woQAqVY+EP9KnLUo6SV1bNagCuG4CyFcPPx5AvuoKcPK hlMTyTVcLovypO7oBoPsJ00SQg0EViX0k+ScJ67WU8/8sMm7MpxTfTpmb9HHxGuwY84a 31WQ5Pt3MX0MummZwo7oyY4RA7sqHnFFYctmMseNA4rmTHJTHv75zulDM5FQKOCrxpog rfpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GCBGFufjjtkKM79QaCqD4gnNbGr/Jp0wwB8/7DPDEJI=; b=UC32QEvR1XFg1vb6Y9aPFy+C264nxVJkNv00CxTFPTY9qu/eIDXv4hxfF6Rp7Dw3d5 Fns4Q2VKuuA/gPYluXorWtJmWNwLTtQZRMqRf12P2RtcJNmLtz8vO5mbW1gj4HSuL1sV hCTae2QeB8BsNC0OX16nt8SLFcCUsphtTP7TgJ/f7oT/T4PURIhB+LWzSiji+oTyXtgw mm0sDKBfMvutGzYXcTnIy28v9mG5nrVV8OdILSQTEcHINjSnYDV858WYzfKz+MieTw6E VGBDXkItAQGhHMOiNHx47poVwVEkU78ysdJ6rFCcUdUWDBAl3wjPXEPvMCviz2k9E2xP ybWA== X-Gm-Message-State: AOAM5321/7nM8gsdv4rxKmCB3i5MH+qjD19/JqlYbWk6EgByYrc+Uoj5 WdxvfFB5MHAfx5G5H1Pci9WtAA== X-Received: by 2002:a37:345:: with SMTP id 66mr248338qkd.358.1612460638075; Thu, 04 Feb 2021 09:43:58 -0800 (PST) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id d16sm5443086qka.44.2021.02.04.09.43.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 09:43:57 -0800 (PST) Date: Thu, 4 Feb 2021 12:43:56 -0500 From: Johannes Weiner To: Muchun Song Cc: mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: memcontrol: replace the loop with a list_for_each_entry() Message-ID: References: <20210204163055.56080-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210204163055.56080-1-songmuchun@bytedance.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2021 at 12:30:55AM +0800, Muchun Song wrote: > The rule of list walk has gone since: > > commit a9d5adeeb4b2 ("mm/memcontrol: allow to uncharge page without using page->lru field") > > So remove the strange comment and replace the loop with a > list_for_each_entry(). > > There is only one caller of the uncharge_list(). So just fold it into > mem_cgroup_uncharge_list() and remove it. > > Signed-off-by: Muchun Song Acked-by: Johannes Weiner Thank you, Muchun!