Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 4 Feb 2021 22:50:00 +0100
From:   Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>
To:     Xiaofei Tan <tanxiaofei@huawei.com>
Cc:     helgaas@kernel.org, sathyanarayanan.kuppuswamy@linux.intel.com,
        sean.v.kelley@intel.com, Jonathan.Cameron@huawei.com,
        refactormyself@gmail.com, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH 1/1] PCI/AER: Change to use helper pcie_aer_is_native()
 in some places
Message-ID: <YBxsCPEFe0lxhDMO@rocinante>
References: <1612420127-6447-1-git-send-email-tanxiaofei@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1612420127-6447-1-git-send-email-tanxiaofei@huawei.com>
Precedence: bulk

Hi Tan,

This is very nice!  Thank you for this.

[...]
>  	if (dev->aer_cap && pci_aer_available() &&
> -	    (pcie_ports_native || host->native_aer)) {
> +	    pcie_aer_is_native(dev)) {
>  		services |= PCIE_PORT_SERVICE_AER;
[...]

A suggestion.  You could improve this even further, for example:

  if (pci_aer_available() && pcie_aer_is_native(dev)) {

This is because the pcie_aer_is_native() function performs the
dev->aer_cap check internally, so we could rely on it, and avoid
checking the same thing twice.

What do you think?

Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

Krzysztof