Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] jfs: Remove unneeded return variable
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org
References: <1612409974-63355-1-git-send-email-yang.lee@linux.alibaba.com>
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
Message-ID: <2ddb278d-22c9-e1e0-9d56-d132192620c5@oracle.com>
Date:   Thu, 4 Feb 2021 16:07:44 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
In-Reply-To: <1612409974-63355-1-git-send-email-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.0.190] (68.201.65.98) by SN7PR04CA0053.namprd04.prod.outlook.com (2603:10b6:806:120::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.17 via Frontend Transport; Thu, 4 Feb 2021 22:07:46 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 86c43db9-166a-4115-871e-08d8c9594dc6
X-MS-TrafficTypeDiagnostic: CH0PR10MB5321:
X-Microsoft-Antispam-PRVS: <CH0PR10MB53212DD963A6C7630F3E95CB87B39@CH0PR10MB5321.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:159;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 6O5urlGI5LTGjjcY/U/dZeVWG6edyCqLG6bdKPEZc2+EBBMjea/imvziTCwevR6FUvj37xzqaWk9lhi6M3vxtKpapERCVQ0HMye3p/LM1T+Aw0dXWxmL/FJr9mT8HBpN5uOZZzAow0HZMA05JVhH0pmbGj6QCSva8+zHB1CagOWjDpvaBwxzDT2TANdeqm+v1vzpMa2QEHsroKWBhJVDhSx97bA5HEhvmDKLv70YCnlFIbj2m/ZlIvRWTZau1g5ZTJuFnuCCmV5mMbH0sPriaA8UCWchALKgwLNO5Id9iFD3K4JBfAsuhJkC0gsC4b27Omeg6asIp3qet/fjwLxeIND418GStmbpQTxx4SV+DB38R+9RcEmSZhZQUibnR/ijGI9e4MAMuylbJhRVOIWtt57qMPw/V9UDcVFP/kWMjqUY6CZMd3oAmA/CSbRFthoXlSzygvYVP2QkOzcDmAEa0vfs5kM5GGIEFp6z+53oN/yo6m0fPSVF5PCe0KqrhYAiEuamaAYZjTcjfj1awzI/0oIPmmJ1SOnKBqCO7lcjhEilxj1Ysr5hKKMZfDdjD6YKAcCZZingWC+7ZNLH+lgbVcdiKqAVzz4AdFnAj6w3dQc=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR10MB4118.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(396003)(346002)(39860400002)(136003)(376002)(2906002)(2616005)(956004)(44832011)(8676002)(86362001)(36756003)(31696002)(6486002)(53546011)(186003)(16526019)(83380400001)(26005)(316002)(16576012)(5660300002)(478600001)(4326008)(31686004)(6916009)(8936002)(66556008)(66476007)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aFMxdmFFQnM5RkhJbys4Sy83Unp5T2FqVDBjeDJFb2ZlVmJ0U3c0bnQxc0JL?=
 =?utf-8?B?OTVwTnBPWEFIbzhBeHBCY24rcVlGaytPdTR6MnBhbU5uU2tQSVl5VjFMKzFR?=
 =?utf-8?B?Uk1NcjV5bklKaW9wclRuUzlpU3o4TUEzU3ZhUXRESHJ0amhWOGdTMXo1WTJF?=
 =?utf-8?B?QmRWdGhjRTM1WGo4Ry9IVFRnZ29ISVVmMTdVbkxvWXhjTS9FVUVUeDNQQ2F0?=
 =?utf-8?B?S25YV05EcnpwemtIa25jb0lLZmcrR28vWjFPOS9uc0RKdnVleUZ0RUVPZFM2?=
 =?utf-8?B?NmRZNk9nS1FmT29ESGloQ1k2OG1PMFZHZ3ZpTlBMUzNZYTZWWmhLYUxjS0hq?=
 =?utf-8?B?ZlFaOTdKeFRzVXBPaUZrNmVUSk16eGE4cUhsTllXbGhxMWtwa2tFUUw5UTJ0?=
 =?utf-8?B?Zy9Db0dXNE56VTliL0ozRmZiSHlxRHdCNy9lcHU2MEF4bW1BdjZacnA4WFBU?=
 =?utf-8?B?SGxEelp3cnQ3RDdCbnBKV0xvUnYwM2k5d3hhMWUyTEx4eDhpT3Jic2VXalpC?=
 =?utf-8?B?enRuVUVlWERYWnF2cWNxNDlYbTFIY21uQUR3ajVvRW9ZK1J2RDJKVG1tcnpv?=
 =?utf-8?B?QmNTVXdhZDZLOVZUV0lJeVNiZXhXN1ljOHlnblRBUW0xU1lVb25xaFpqYTRC?=
 =?utf-8?B?Q2FVSzZnTEoyNEVSaEdmeVMyRkpuNmR2N2lHWkxZQWdzdFQ5NXBCWTl6eEpr?=
 =?utf-8?B?T3dVZlJoRUhVbWtnYVFhclIxQXdnQTlDdFVFSUphdFI2MWRkVHMxU250ZGRL?=
 =?utf-8?B?czNjNDR3YkNlVFlNSjQvVm5VMnNyVnRRQjlud212Ni9jN3NjUlUrTmw5Y0RI?=
 =?utf-8?B?OHBrWGxTdVk1WllvbjRtTmxkY3FBTExCRzlRVjNacTExZmU5UmhnWnZZYmY0?=
 =?utf-8?B?QmZubDRTUno0MGxIeEJpQjFtNzVRTlpTcFZEelNhbW9ESDFrZ1FFMW9BMWJ3?=
 =?utf-8?B?OEtKd0F0L1dBVDZVNmQ3QVBLQ2dzVkt6U09lRnd2STVZRFVnV2RwQnpvblRw?=
 =?utf-8?B?ajlSK0NlWE9ob0cvVU1xODVGY3NyM2cweW1Xd2Qzdm82b2FZcDU1dXB0ZVpZ?=
 =?utf-8?B?UWRubEs0RGRwbGozbEJHalhUcTByempjWkxyeVB6RFNoVXNFK3hpQkdSdTZX?=
 =?utf-8?B?Y25vaUIvSUlZRlJJR3FDd1poZEdtTURZWjBpNnRXWUJnQ2VzLzJ0K0YxRmUx?=
 =?utf-8?B?UXBWS2FyK1Z6Vk1YTTF0bkRxeEFNaCtaemxEVUlTaXNKTjU2ck9SSkxHMElk?=
 =?utf-8?B?N3c2czUyeFFtSlBhcXNxZGEwWG8vcDVVSGNmczJlRXgvMVdxYmVrR2ZrM0Va?=
 =?utf-8?B?UkFQYm9hUjV3ZVIrTjRMWkhrcWR5dW9uUm1ESlllSnI2aVhnMHlsR2s2Vk5s?=
 =?utf-8?B?TXFGQUNyQ0d6VHpFSkY0Tjg3V1pENGNEaGdxL0FRRUN4UndGZFYxQ05IQlF5?=
 =?utf-8?Q?oZCjMbN6?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86c43db9-166a-4115-871e-08d8c9594dc6
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4118.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2021 22:07:47.0379
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l+tjxq1XeaItF/mNFoP0aXslYHtTagWI9MSOCO/GJnKvGpMOw3CTQf84W7Qfeb/9rDUvW0RmPUdVt5ayDcIWRMvS7Hg5QdjttVz6F/086NE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5321
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9885 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 suspectscore=0
 spamscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102040133
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9885 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 mlxscore=0 priorityscore=1501 spamscore=0 impostorscore=0 clxscore=1011
 suspectscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102040133
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/3/21 9:39 PM, Yang Li wrote:
> This patch removes unneeded return variables, using only
> '0' instead.
> It fixes the following warning detected by coccinelle:
> ./fs/jfs/jfs_txnmgr.c:1370:5-7: Unneeded variable: "rc". Return "0" on
> line 1417

Looks good. I wonder if we should take it a step further and turn 
diLog(), dataLog() and txLog() into void functions.

Shaggy

> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>   fs/jfs/jfs_txnmgr.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c
> index dca8edd..87ef2a2 100644
> --- a/fs/jfs/jfs_txnmgr.c
> +++ b/fs/jfs/jfs_txnmgr.c
> @@ -1367,7 +1367,6 @@ int txCommit(tid_t tid,		/* transaction identifier */
>    */
>   static int txLog(struct jfs_log * log, struct tblock * tblk, struct commit * cd)
>   {
> -	int rc = 0;
>   	struct inode *ip;
>   	lid_t lid;
>   	struct tlock *tlck;
> @@ -1414,7 +1413,7 @@ static int txLog(struct jfs_log * log, struct tblock * tblk, struct commit * cd)
>   		}
>   	}
>   
> -	return rc;
> +	return 0;
>   }
>   
>   /*
> @@ -1425,7 +1424,6 @@ static int txLog(struct jfs_log * log, struct tblock * tblk, struct commit * cd)
>   static int diLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
>   		 struct tlock * tlck, struct commit * cd)
>   {
> -	int rc = 0;
>   	struct metapage *mp;
>   	pxd_t *pxd;
>   	struct pxd_lock *pxdlock;
> @@ -1527,7 +1525,7 @@ static int diLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
>   	}
>   #endif				/* _JFS_WIP */
>   
> -	return rc;
> +	return 0;
>   }
>   
>   /*
>