Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1518199pxb; Thu, 4 Feb 2021 15:28:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJwY4aLqjXid9M+QDCL1hvq7IU8hd/OqO3G8XGPaqMqQ0bI2Doums3+A4aNEL3MqXLHNFwIi X-Received: by 2002:a17:906:7754:: with SMTP id o20mr1439566ejn.192.1612481285402; Thu, 04 Feb 2021 15:28:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612481285; cv=none; d=google.com; s=arc-20160816; b=mxuDHBeRhHI0VZHKpGrYlqxWvDwIQc8bbspnPEvPpvmLp4hQ7IkrHh5drdgyfk8daj CmSbRSwz089KL5SoqUe4WW7R+CFIGENDc7ni7hOV1zzqgGeHnaLhmqjQa8jV9Rng6Rnc bVwvnFz6KV5ZFUMttryXO5rdX08Pr93WzaeokAH5UV8QeBTduhbEWufDkYZigQsMNwYk kVSt9H0lKfyKV62oFHXbhQsbAm0VW8qgV0nZq4dWAI88876aC8xEH4SL70OLyD6O18Vt 9RHU9nnk1Cz5Bx9uu+1SWsHYUJLLxk3JAJrwA8Cp4NRufUW7MQnJBasEXmbxGHPaV/no mu6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=viXgfIxv7i0d74SKlkFX/zmJBkL8tEFrX2ISUYlZPDg=; b=vAEul88ULUTHdIvuhJIva0M7gADxDUqj84smOVx+dpCDHoQXR+AL2frSWdyErOIHKW Eg6yolRuYFZ/lW9rAGLstVT9l+Pzaf2gVTyQD6f+ASRZoMs3JYokzvnZ1QVyyBgaNXMo ffI6HF8DkMLaRXoiIt/y738VyWoGNYQufe4WcVn2+YvHYPR+3jtmdNIAGL5PDv0r2qXC 28OtjgTs0yXj86sQUQtA96fgsH9rKvB1yEwqR6Pfzn+ZBN43Omj6CBhfHQhs13EFVwU1 qyCvpaF8lZKy2aTQnr2nlsde4wsfChHJxjEMHqqTHPoGn7RITu60DJ90GGblPYPGi/tQ 5E1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v10si4025222ejg.86.2021.02.04.15.27.40; Thu, 04 Feb 2021 15:28:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233253AbhBDHSd (ORCPT + 99 others); Thu, 4 Feb 2021 02:18:33 -0500 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:35254 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231791AbhBDHSZ (ORCPT ); Thu, 4 Feb 2021 02:18:25 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UNpW3vb_1612423059; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UNpW3vb_1612423059) by smtp.aliyun-inc.com(127.0.0.1); Thu, 04 Feb 2021 15:17:39 +0800 From: Yang Li To: njavali@marvell.com Cc: mrangankar@marvell.com, GR-QLogic-Storage-Upstream@marvell.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] scsi: qla4xxx: Remove unneeded return variable Date: Thu, 4 Feb 2021 15:17:37 +0800 Message-Id: <1612423057-72018-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch removes unneeded return variables, using only '0' instead. It fixes the following warning detected by coccinelle: ./drivers/scsi/qla4xxx/ql4_os.c:3642:5-7: Unneeded variable: "rc". Return "0" on line 3741 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/scsi/qla4xxx/ql4_os.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index a4b014e..ed92534 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -3639,7 +3639,6 @@ static int qla4xxx_copy_to_fwddb_param(struct iscsi_bus_flash_session *sess, struct dev_db_entry *fw_ddb_entry) { uint16_t options; - int rc = 0; options = le16_to_cpu(fw_ddb_entry->options); SET_BITVAL(conn->is_fw_assigned_ipv6, options, BIT_11); @@ -3738,7 +3737,7 @@ static int qla4xxx_copy_to_fwddb_param(struct iscsi_bus_flash_session *sess, COPY_ISID(fw_ddb_entry->isid, sess->isid); - return rc; + return 0; } static void qla4xxx_copy_to_sess_conn_params(struct iscsi_conn *conn, -- 1.8.3.1