Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1520907pxb; Thu, 4 Feb 2021 15:32:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJxssXebG8ISwfcjAU+uAHyJ5EPcjLkDyACtGNiR05G95cV19noNX1sS1+auiVvJ7LmZMDzF X-Received: by 2002:a05:6402:149a:: with SMTP id e26mr955228edv.254.1612481578235; Thu, 04 Feb 2021 15:32:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612481578; cv=none; d=google.com; s=arc-20160816; b=PgjfW5rMiaxPbX5jEkTZCtFD8flG/91HIBog9ONrA0TuAI+R/xTqM08aDdxJSuoUVg 7kkuW7XwTQPYSL49nwoXA+Mud11qIW/dLS2OWzrIU9yDYDzNRwOqW4HIUwYhzJJESHsC dLc7O2G4MY7svKZliNfL5orLSpLyxhFz4l1NTTqvLXevWUjT9l4BhPDiQHDQeo2JwnYp SR0UGKzHVXZo/746OO/ZtN+VpgucZtVP6bd2dMiZ5Qf0uRm+8OH8RMdffqJsFM4qz5tV by5nkZ3L9Lye8gfwjsXKdPyz0+9pFK/uSr/9fMGF7+CNRlxb77zP8jskk/89CdiuOIgN tqrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Qf2GiT5eCzuq3xbl+xSf4hvyk5rYNy2ZyvCJbvzvknE=; b=f650kyqI8jXjfp84EgJt6x+/4aFqB1ykQRj8XZotHVgTXEtHU+tGeKWIlrtHlNTWb8 Fa+jXQ3NhMa25r6nTCmFo7ike2O6XNv2kB8o+IW4wQa4RYVl3Ulv27zkgJvoIahbARch 6QP202sDFOnnOckyGOjNHuL9Tu3lBz1bo9WPiXgVnli83KQGNny27xSyFaPjo/EqVerZ IvzmC8xezSmYr3kjQjXnK7hzYmeY254n+3ZaY68QnCKQ2xp38H0pKBh6pnzTJXzmlG+u cgTgXYsygC4svnW09RJz2dL1gc95IhATjSn9Z5KYUINTHcx8pD3YMsSkuhp04pN06/bJ 4K5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t5si4086593edd.296.2021.02.04.15.32.33; Thu, 04 Feb 2021 15:32:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234950AbhBDIlL (ORCPT + 99 others); Thu, 4 Feb 2021 03:41:11 -0500 Received: from verein.lst.de ([213.95.11.211]:54996 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234897AbhBDIlK (ORCPT ); Thu, 4 Feb 2021 03:41:10 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 77E4067373; Thu, 4 Feb 2021 09:40:23 +0100 (CET) Date: Thu, 4 Feb 2021 09:40:23 +0100 From: Christoph Hellwig To: Dongli Zhang Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, nouveau@lists.freedesktop.org, x86@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, adrian.hunter@intel.com, akpm@linux-foundation.org, benh@kernel.crashing.org, bskeggs@redhat.com, bhelgaas@google.com, bp@alien8.de, boris.ostrovsky@oracle.com, hch@lst.de, chris@chris-wilson.co.uk, daniel@ffwll.ch, airlied@linux.ie, hpa@zytor.com, mingo@kernel.org, mingo@redhat.com, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, jgross@suse.com, konrad.wilk@oracle.com, m.szyprowski@samsung.com, matthew.auld@intel.com, mpe@ellerman.id.au, rppt@kernel.org, paulus@samba.org, peterz@infradead.org, robin.murphy@arm.com, rodrigo.vivi@intel.com, sstabellini@kernel.org, bauerman@linux.ibm.com, tsbogend@alpha.franken.de, tglx@linutronix.de, ulf.hansson@linaro.org, joe.jin@oracle.com, thomas.lendacky@amd.com Subject: Re: [PATCH RFC v1 5/6] xen-swiotlb: convert variables to arrays Message-ID: <20210204084023.GA32328@lst.de> References: <20210203233709.19819-1-dongli.zhang@oracle.com> <20210203233709.19819-6-dongli.zhang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210203233709.19819-6-dongli.zhang@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org So one thing that has been on my mind for a while: I'd really like to kill the separate dma ops in Xen swiotlb. If we compare xen-swiotlb to swiotlb the main difference seems to be: - additional reasons to bounce I/O vs the plain DMA capable - the possibility to do a hypercall on arm/arm64 - an extra translation layer before doing the phys_to_dma and vice versa - an special memory allocator I wonder if inbetween a few jump labels or other no overhead enablement options and possibly better use of the dma_range_map we could kill off most of swiotlb-xen instead of maintaining all this code duplication?