Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: nL+K9OBZyCJQB1X/EOtOd/9n2ixDFmjQQ9g+BAsxmovqa/Vzvcjk0kwJVclhhYevkSvERSw+/g
 4bh97FAYXwPhTdd/ST/kcRtI3kZVJusBYBbF1BFzVvdAp37flarZl90W4Uw8pfg6fhOG92bzr9
 /6A3ypAKa9zmUEpNQ8d9IvU8fyM4NrPgKdDT4+JkWTAVJ43nhkH0eBAAselmaE3vClT67hei1n
 HDzjKfuUo5d4ibgA0HzlUCGJ5f65XK5I9n8dedrMziUqom15ukr4YrvIQrrmpZARB2KhqYcMSb
 zxQ=
From:   Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To:     Yang Li <yang.lee@linux.alibaba.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>
CC:     "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "brking@us.ibm.com" <brking@us.ibm.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: ipr: Remove unneeded return variable
Thread-Topic: [PATCH] scsi: ipr: Remove unneeded return variable
Thread-Index: AQHW+sdPjcW8ddogR0uDkhrg8dfJcw==
Date:   Thu, 4 Feb 2021 09:33:06 +0000
Message-ID: <SN4PR0401MB35981D9E1825962920A0CB6E9BB39@SN4PR0401MB3598.namprd04.prod.outlook.com>
References: <1612423568-81006-1-git-send-email-yang.lee@linux.alibaba.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 74315d2f-1025-4765-2642-08d8c8efe109
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2021 09:33:06.9978
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FsLh/8EulViacvtZdWVsHEQQbDVRhE5MmTlswFew+P5q6dQVtPPL/zjwR77UUrIPenQ+NG0OwW0SkH/u4IxrZ6LEKcv4H3MUdHzfnDRXsuI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0401MB3599
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/02/2021 08:28, Yang Li wrote:=0A=
> This patch removes unneeded return variables, using only=0A=
> '0' instead.=0A=
> It fixes the following warning detected by coccinelle:=0A=
> ./drivers/scsi/ipr.c:9508:5-7: Unneeded variable: "rc". Return "0" on=0A=
> line 9524=0A=
> =0A=
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>=0A=
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>=0A=
> ---=0A=
>  drivers/scsi/ipr.c | 3 +--=0A=
>  1 file changed, 1 insertion(+), 2 deletions(-)=0A=
> =0A=
> diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c=0A=
> index e451102..8eced7c 100644=0A=
> --- a/drivers/scsi/ipr.c=0A=
> +++ b/drivers/scsi/ipr.c=0A=
> @@ -9505,7 +9505,6 @@ static pci_ers_result_t ipr_pci_error_detected(stru=
ct pci_dev *pdev,=0A=
>   **/=0A=
>  static int ipr_probe_ioa_part2(struct ipr_ioa_cfg *ioa_cfg)=0A=
>  {=0A=
> -	int rc =3D 0;=0A=
>  	unsigned long host_lock_flags =3D 0;=0A=
>  =0A=
>  	ENTER;=0A=
> @@ -9521,7 +9520,7 @@ static int ipr_probe_ioa_part2(struct ipr_ioa_cfg *=
ioa_cfg)=0A=
>  	spin_unlock_irqrestore(ioa_cfg->host->host_lock, host_lock_flags);=0A=
>  =0A=
>  	LEAVE;=0A=
> -	return rc;=0A=
> +	return 0;=0A=
>  }=0A=
>  =0A=
>  /**=0A=
> =0A=
=0A=
As it's always returning 0 this is dead code as well:=0A=
=0A=
	rc =3D ipr_probe_ioa_part2(ioa_cfg);=0A=
=0A=
	if (rc) {=0A=
		__ipr_remove(pdev);=0A=
		return rc;=0A=
	}=0A=
=0A=
I think:=0A=
- static int ipr_probe_ioa_part2(struct ipr_ioa_cfg *ioa_cfg)=0A=
+ static void ipr_probe_ioa_part2(struct ipr_ioa_cfg *ioa_cfg)=0A=
=0A=
is the right thing to do if you really want to touch it.=0A=
=0A=
=0A=
=0A=