Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 03XCtq6Nzugsi4RhOpDrgoqSGW08f/JllqGi1IMy7MJPFgZVEvO7eckRQjUx3NjGGh0AiLJe6Z
 ZIM5pO3+3fXzQOcJ/Pw2Zpnmx+f7Zdv3zZo0u7VXYCsxZIreOGifpw5HjSQM9ZDUxKz+D7l6Gn
 Bg/EWz8eHP4aCt8F8W/kxsq7bIVRLk1ovm8CW1mKs9WxiXc5ADC+dOfSpZPpktiXYK/+lClQAi
 424VITYHYltB25TWq6JTWwFe8w/6aiOhnZEeJqy6XbZWhROvuffN8RKvfk40r+T5tpiSl9eAr0
 yeg=
From:   Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To:     Yang Li <yang.lee@linux.alibaba.com>,
        "njavali@marvell.com" <njavali@marvell.com>
CC:     "mrangankar@marvell.com" <mrangankar@marvell.com>,
        "GR-QLogic-Storage-Upstream@marvell.com" 
        <GR-QLogic-Storage-Upstream@marvell.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: qla4xxx: Remove unneeded return variable
Thread-Topic: [PATCH] scsi: qla4xxx: Remove unneeded return variable
Thread-Index: AQHW+sYuEnydvZTO4EK6h+U4cJLxOQ==
Date:   Thu, 4 Feb 2021 09:35:16 +0000
Message-ID: <SN4PR0401MB359888143238B80B16BFA67A9BB39@SN4PR0401MB3598.namprd04.prod.outlook.com>
References: <1612423057-72018-1-git-send-email-yang.lee@linux.alibaba.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cd26223-d8a5-412d-38af-08d8c8f02e3a
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2021 09:35:16.5339
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1OOd3xqakjHu/cXTTDxYGXvnWbvulbhU8vfr8s83IxmpM8d5drukE+ZbBs6QbcPyPlDkGA35/lxiLl29zA0uvLE1qCwkHEEljdJlsfgRVTM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR04MB2141
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/02/2021 08:20, Yang Li wrote:=0A=
> This patch removes unneeded return variables, using only=0A=
> '0' instead.=0A=
> It fixes the following warning detected by coccinelle:=0A=
> ./drivers/scsi/qla4xxx/ql4_os.c:3642:5-7: Unneeded variable: "rc".=0A=
> Return "0" on line 3741=0A=
> =0A=
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>=0A=
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>=0A=
> ---=0A=
>  drivers/scsi/qla4xxx/ql4_os.c | 3 +--=0A=
>  1 file changed, 1 insertion(+), 2 deletions(-)=0A=
> =0A=
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.=
c=0A=
> index a4b014e..ed92534 100644=0A=
> --- a/drivers/scsi/qla4xxx/ql4_os.c=0A=
> +++ b/drivers/scsi/qla4xxx/ql4_os.c=0A=
> @@ -3639,7 +3639,6 @@ static int qla4xxx_copy_to_fwddb_param(struct iscsi=
_bus_flash_session *sess,=0A=
>  				       struct dev_db_entry *fw_ddb_entry)=0A=
>  {=0A=
>  	uint16_t options;=0A=
> -	int rc =3D 0;=0A=
>  =0A=
>  	options =3D le16_to_cpu(fw_ddb_entry->options);=0A=
>  	SET_BITVAL(conn->is_fw_assigned_ipv6,  options, BIT_11);=0A=
> @@ -3738,7 +3737,7 @@ static int qla4xxx_copy_to_fwddb_param(struct iscsi=
_bus_flash_session *sess,=0A=
>  =0A=
>  	COPY_ISID(fw_ddb_entry->isid, sess->isid);=0A=
>  =0A=
> -	return rc;=0A=
> +	return 0;=0A=
>  }=0A=
>  =0A=
>  static void qla4xxx_copy_to_sess_conn_params(struct iscsi_conn *conn,=0A=
> =0A=
=0A=
None of the callers checks the return value anyways so you can do:=0A=
- static int qla4xxx_copy_to_fwddb_param(struct iscsi_bus_flash_session *se=
ss,=0A=
+ static void qla4xxx_copy_to_fwddb_param(struct iscsi_bus_flash_session *s=
ess,=0A=