Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210204081819.892660-1-zhang.lyra@gmail.com>
In-Reply-To: <20210204081819.892660-1-zhang.lyra@gmail.com>
From:   Baolin Wang <baolin.wang7@gmail.com>
Date:   Thu, 4 Feb 2021 18:59:37 +0800
Message-ID: <CADBw62qRZ77FM7S=ss3urJ+sB_P3VSYKt2hf6cWiPk8WPoo5-A@mail.gmail.com>
Subject: Re: [PATCH] mailbox: sprd: correct definition of SPRD_OUTBOX_FIFO_FULL
To:     Chunyan Zhang <zhang.lyra@gmail.com>
Cc:     Jassi Brar <jassisinghbrar@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <chunyan.zhang@unisoc.com>,
        Magnum Shan <magnum.shan@unisoc.com>,
        Haidong Yao <haidong.yao@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Feb 4, 2021 at 4:18 PM Chunyan Zhang <zhang.lyra@gmail.com> wrote:
>
> From: Magnum Shan <magnum.shan@unisoc.com>
>
> According to the specification, bit[2] represents SPRD_OUTBOX_FIFO_FULL,
> not bit[0], so correct it.
>
> Fixes: ca27fc26cd22 ("mailbox: sprd: Add Spreadtrum mailbox driver")
> Signed-off-by: Magnum Shan <magnum.shan@unisoc.com>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>

LGTM.
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>

> ---
>  drivers/mailbox/sprd-mailbox.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/sprd-mailbox.c b/drivers/mailbox/sprd-mailbox.c
> index f6fab24ae8a9..4c325301a2fe 100644
> --- a/drivers/mailbox/sprd-mailbox.c
> +++ b/drivers/mailbox/sprd-mailbox.c
> @@ -35,7 +35,7 @@
>  #define SPRD_MBOX_IRQ_CLR                      BIT(0)
>
>  /* Bit and mask definiation for outbox's SPRD_MBOX_FIFO_STS register */
> -#define SPRD_OUTBOX_FIFO_FULL                  BIT(0)
> +#define SPRD_OUTBOX_FIFO_FULL                  BIT(2)
>  #define SPRD_OUTBOX_FIFO_WR_SHIFT              16
>  #define SPRD_OUTBOX_FIFO_RD_SHIFT              24
>  #define SPRD_OUTBOX_FIFO_POS_MASK              GENMASK(7, 0)
> --
> 2.25.1
>


-- 
Baolin Wang