Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210111140814.3668-1-brgl@bgdev.pl>
In-Reply-To: <20210111140814.3668-1-brgl@bgdev.pl>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Thu, 4 Feb 2021 13:37:52 +0100
Message-ID: <CAMRc=MfeAokkWdHNS1HES07YBFX6kM_JZRFehk0F+sB552_UbQ@mail.gmail.com>
Subject: Re: [PATCH] clocksource: davinci: move pr_fmt() before the includes
To:     Daniel Lezcano <daniel.lezcano@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        David Lechner <david@lechnology.com>,
        Sekhar Nori <nsekhar@ti.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jan 11, 2021 at 3:08 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> We no longer need to undef pr_fmt if we define our own before including
> any headers.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
>  drivers/clocksource/timer-davinci.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clocksource/timer-davinci.c b/drivers/clocksource/timer-davinci.c
> index bb4eee31ae08..9996c0542520 100644
> --- a/drivers/clocksource/timer-davinci.c
> +++ b/drivers/clocksource/timer-davinci.c
> @@ -7,6 +7,8 @@
>   * (with tiny parts adopted from code by Kevin Hilman <khilman@baylibre.com>)
>   */
>
> +#define pr_fmt(fmt) "%s: " fmt, __func__
> +
>  #include <linux/clk.h>
>  #include <linux/clockchips.h>
>  #include <linux/interrupt.h>
> @@ -17,9 +19,6 @@
>
>  #include <clocksource/timer-davinci.h>
>
> -#undef pr_fmt
> -#define pr_fmt(fmt) "%s: " fmt, __func__
> -
>  #define DAVINCI_TIMER_REG_TIM12                        0x10
>  #define DAVINCI_TIMER_REG_TIM34                        0x14
>  #define DAVINCI_TIMER_REG_PRD12                        0x18
> --
> 2.29.1
>

Gentle ping.

Bart