Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1612287314-5384-1-git-send-email-oliver.graute@gmail.com>
In-Reply-To: <1612287314-5384-1-git-send-email-oliver.graute@gmail.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Thu, 4 Feb 2021 15:22:29 -0300
Message-ID: <CAOMZO5CDhUprEn8umeBa0Y3kvU1qSawqJ2Y0-F-EMakmLOu4BQ@mail.gmail.com>
Subject: Re: [PATCH v3] drm/panel: simple: add SGD GKTW70SDAD1SD
To:     Oliver Graute <oliver.graute@gmail.com>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Marco Felsch <m.felsch@pengutronix.de>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        DRI mailing list <dri-devel@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Oliver,

On Tue, Feb 2, 2021 at 2:35 PM Oliver Graute <oliver.graute@gmail.com> wrote:

> +static const struct panel_desc sgd_gktw70sdad1sd = {
> +       .timings = &sgd_gktw70sdad1sd_timing,
> +       .num_timings = 1,
> +       .bpc = 6,
> +       .size = {
> +               .width = 153,
> +               .height = 86,
> +       },
> +       .delay = {
> +               .prepare = 20 + 20 + 10 + 10,

Adding the datasheet label like Marco suggested make it clearer where
these numbers come from : /* T0 + T2 + T3 + T4 */

Glad you got it working on your imx6ul board:

Reviewed-by: Fabio Estevam <festevam@gmail.com>