Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1582044pxb; Thu, 4 Feb 2021 17:33:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJyxwOJTKngWYsLz3I1DOg7wjBZzkZVZjI9cNUBSRYdIfof/xvR9INK4QI8mT/LWSRwqtDeM X-Received: by 2002:a17:906:9401:: with SMTP id q1mr1817290ejx.516.1612488829377; Thu, 04 Feb 2021 17:33:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612488829; cv=none; d=google.com; s=arc-20160816; b=AWbu8W19Ra6S60kd38qCDsVi3LLu1q1sz9PESNrNd0+AHtbkkXRUi22X0jmkN9vtX7 SYyLGMIUdv4PSfZ7Tvsx1EheShahmNRcFhdtZiwYUcrYki4vKyxZaOO0sLUwhOTJ+Azn ut9AVU43lWrCVjZlr3jjGlxbDuEk8SHTLJlnFVlxzVT1jeIkWcuJB2+Lk8pOUaewmhSw slDzxMGj4338FyRV15Qp1370ysA87HIGTsnOJD97YfGvMf7lMia0zc0dh4hfbuhUdbUX +8TjiLuriPVBTAUTnfBFbR6rhSUiI8DUftVo0bQW92JA0hajdMeXmCYZHwXW8TADlVsX VKug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Gak1fHyFP8eBDj1H5ooHi1nufpwIs8RioUJ6J9YokuE=; b=XiyzJy0BhSfXL78Ma0SsEK5SUcfka2SJbIhyh9jwkyFczlhISn7dEIl+XKwAY6WlX8 ghOl8uumHhIauizWwUK8NH//dY7XAMD0XGO8Ou8iyurbISMXVm90u0RBZilHPb3auCxZ O50hTbhCrgsRK8Ws688XQtzmVnCecRoQuam0e6p4bRh48XunumCG6+JrKtIaLofJDrGP lIWXf6SlmXZAdRKo9rWYUkzxiVvaERRakbEF7WjpzTHdu/4dRKdebkeNR6jtTgfIuTNv FTTl1ae4siFUzrVhgPtnNjR1gpzJLChe3M3TJDmgtHnX1CeAFwQ0mBWwADj3cIvcI7q8 GbJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siol.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bt20si4293340edb.234.2021.02.04.17.33.25; Thu, 04 Feb 2021 17:33:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siol.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239384AbhBDStL (ORCPT + 99 others); Thu, 4 Feb 2021 13:49:11 -0500 Received: from mailoutvs34.siol.net ([185.57.226.225]:59536 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S239386AbhBDSs6 (ORCPT ); Thu, 4 Feb 2021 13:48:58 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id E017F523FAF; Thu, 4 Feb 2021 19:48:11 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta11.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta11.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Jkndiio0b4pd; Thu, 4 Feb 2021 19:48:11 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id 97FE0523FBF; Thu, 4 Feb 2021 19:48:11 +0100 (CET) Received: from kista.localdomain (cpe-86-58-58-53.static.triera.net [86.58.58.53]) (Authenticated sender: 031275009) by mail.siol.net (Postfix) with ESMTPSA id 9F790523FAF; Thu, 4 Feb 2021 19:48:10 +0100 (CET) From: Jernej Skrabec To: mripard@kernel.org, wens@csie.org Cc: mturquette@baylibre.com, sboyd@kernel.org, airlied@linux.ie, daniel@ffwll.ch, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com Subject: [PATCH 0/5] sunxi: fix H6 HDMI related issues Date: Thu, 4 Feb 2021 19:47:05 +0100 Message-Id: <20210204184710.1880895-1-jernej.skrabec@siol.net> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Over the year I got plenty of reports of troubles with H6 HDMI signal. Sometimes monitor flickers, sometimes there was no image at all and sometimes it didn't play well with AVR. It turns out there are multiple issues. Patch 1 fixes clock issue, which didn't adjust parent rate, even if it is allowed to do so. Patch 2 adds polarity config in tcon1. This is seemingly not needed for pre-HDMI2 controllers, although BSP drivers set it accordingly every time. It turns out that HDMI2 controllers often don't work with monitors if polarity is not set correctly. Patch 3 always set clock rate for HDMI controller. Patch 4 fixes cpce PHY setting for 594 MHz. Patch 5 fixes comment and clock rate limit (wrong reasoning). Please take a look. Best regards, Jernej Jernej Skrabec (5): clk: sunxi-ng: mp: fix parent rate change flag check drm/sun4i: tcon: set sync polarity for tcon1 channel drm/sun4i: dw-hdmi: always set clock rate drm/sun4i: Fix H6 HDMI PHY configuration drm/sun4i: dw-hdmi: Fix max. frequency for H6 drivers/clk/sunxi-ng/ccu_mp.c | 2 +- drivers/gpu/drm/sun4i/sun4i_tcon.c | 24 ++++++++++++++++++++++++ drivers/gpu/drm/sun4i/sun4i_tcon.h | 5 +++++ drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 10 +++------- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 1 - drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c | 2 +- 6 files changed, 34 insertions(+), 10 deletions(-) --=20 2.30.0